-
Notifications
You must be signed in to change notification settings - Fork 2k
Migrate OpenShift & Plus secrets to Azure Vault #8515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates secret management from GitHub Secrets to Azure Key Vault for improved security and centralized secret management. The changes establish Azure Vault integration for OpenShift certification credentials and NGINX Plus JWT tokens, while removing unused AWS Marketplace secrets and making minor improvements to the build process.
Key Changes:
- Integrated Azure Key Vault authentication across multiple GitHub workflows
- Migrated OpenShift certification secrets (PYAXIS tokens and project IDs) to Azure Vault
- Migrated NGINX Plus JWT credentials to Azure Vault
- Removed unused AWS Marketplace environment variables
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/update-docker-images.yml |
Added Azure login and secret retrieval for OpenShift certification |
.github/workflows/single-image-regression.yml |
Added Azure login and Plus JWT secret retrieval for regression tests |
.github/workflows/setup-smoke.yml |
Added Azure login and Plus JWT secret retrieval for smoke tests |
.github/workflows/release.yml |
Added Azure login and secret retrieval for release certification |
.github/workflows/regression.yml |
Added Azure login and Plus JWT secret retrieval for regression and helm tests |
.github/workflows/image-promotion.yml |
Added Azure login and secret retrieval for image promotion certification |
.github/workflows/ci.yml |
Added Azure login and Plus JWT secret retrieval for CI helm tests |
.github/workflows/certify-ubi-image.yml |
Added Azure login and secret retrieval for UBI image certification |
.github/workflows/build-artifacts.yml |
Removed unused AWS Marketplace secrets and relocated netrc cleanup |
Makefile |
Modified GoReleaser command to support configurable GOOS and removed debug flag |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8515 +/- ##
==========================================
+ Coverage 53.65% 53.75% +0.10%
==========================================
Files 91 91
Lines 18285 18342 +57
==========================================
+ Hits 9811 9860 +49
- Misses 7963 7967 +4
- Partials 511 515 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| - name: Cleanup netrc | ||
| run: rm -f $HOME/.netrc | ||
| if: ${{ always() }} | ||
| # - name: Cleanup netrc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to keep it as it's part of the assertion doc job which is likely to come back soon.
Proposed changes
Checklist
Before creating a PR, run through this checklist and mark each as complete.