Skip to content

Update Credits to reflect current maintainership #1619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 25, 2025
Merged

Update Credits to reflect current maintainership #1619

merged 5 commits into from
Nov 25, 2025
+7 −6

Conversation

@pinin4fjords
Copy link
Member

@pinin4fjords pinin4fjords commented Nov 14, 2025

Updates README Credits and nextflow.config to properly credit @pinin4fjords as current maintainer.

Closes #1596

🤖 Generated with Claude Code

@pinin4fjords @claude
Update Credits section to reflect current maintainership
ec4a489 
Updated the README Credits section and nextflow.config manifest to properly credit Jonathan Manning (@pinin4fjords) as the current maintainer of the pipeline, while acknowledging the nf-core community's ongoing contributions.

Changes:
- README: Updated Credits to state pipeline is "currently maintained by Jonathan Manning and the nf-core community"
- nextflow.config: Updated Jonathan Manning's contribution from ['maintainer', 'contributor'] to ['author', 'maintainer']

Closes #1596

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@pinin4fjords pinin4fjords linked an issue Nov 14, 2025 that may be closed by this pull request
Update Credits section of the README. #1596
Closed
@github-actions
Copy link

github-actions bot commented Nov 14, 2025 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit f0f1ef7

+| ✅ 284 tests passed       |+
#| ❔   8 tests were ignored |#
#| ❔   1 tests had warnings |#
!| ❗   9 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: assets/multiqc_config.yml
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in nextflow.config: Specify any additional parameters here
  • pipeline_if_empty_null - ifEmpty(null) found in /home/runner/work/rnaseq/rnaseq/subworkflows/local/prepare_genome/main.nf: _ versions = ch_versions.ifEmpty(null) // channel: [ versions.yml ]
    _

❔ Tests ignored:

❔ Tests fixed:

✅ Tests passed:

Run details

  • nf-core/tools version 3.5.1
  • Run at 2025-11-25 17:37:57

@pinin4fjords pinin4fjords added this to the 3.22.0 milestone Nov 14, 2025
@nf-core-bot
Copy link
Member

nf-core-bot commented Nov 25, 2025

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.4.1.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@pinin4fjords pinin4fjords merged commit 6e0f7b6 into dev Nov 25, 2025
33 checks passed
@pinin4fjords pinin4fjords deleted the update-credits-maintainer branch November 25, 2025 17:53
@pinin4fjords pinin4fjords mentioned this pull request Nov 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxulysse maxulysse maxulysse approved these changes

Assignees

No one assigned

Labels

Review & Merge

Projects

None yet

Milestone

3.22.0

Development

Successfully merging this pull request may close these issues.

Update Credits section of the README.

4 participants

@pinin4fjords @nf-core-bot @maxulysse