Skip to content

Conversation

@joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented Jun 14, 2024

HTMLSerializer uses the path the library is installed it as the cache by default. Since other Nc apps use HTMLSerialize, the app who's copy of HTMLSerialize happens to get used first, ends up with a bunch of stray cache files. Besides being messy, this brings things like integrity checks.

See nextcloud/mail#9731
FIxes nextcloud/mail#9731

There are three choices here:

  • disable the cache (this what the Nc mail app does)
  • leave it enabled by specifying a path
  • accept it as is

Performance impact of disabling is unknown. If we eventually want this enabled still in Pico, we can set Cache.SerializePath to somewhere we're comfortable saving data (locally on the instance...).

Ref: http://htmlpurifier.org/live/configdoc/plain.html#Cache.DefinitionImpl

PhrozenByte and others added 30 commits December 14, 2019 15:31
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
Adding Pico's DummyPlugin as example plugin hopefully encourages users to develop their own plugins 😃

Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
Closes #123

Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
Spelling unification in Transifex.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
nextcloud-bot and others added 23 commits February 22, 2024 00:34
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
HTMLSerializer uses the path the library is installed it as the cache by default. Since other Nc apps use HTMLSerialize, the app who's copy of HTMLSerialize happens to get used first, ends up with a bunch of stray cache files. Besides being messy, this brings things like integrity checks.

See nextcloud/mail#9731

There are three choices here:

- disable the cache (this what the Nc `mail` app does)
- leave it enabled by specifying a path
- accept it as is

Performance impact of disabling is unknown. If we eventually want this enabled still in Pico, we can set `Cache.SerializePath` to somewhere we're comfortable saving data (locally on the instance...). 

Ref: http://htmlpurifier.org/live/configdoc/plain.html#Cache.DefinitionImpl

Signed-off-by: Josh <josh.t.richards@gmail.com>
@PhrozenByte
Copy link
Member

Good catch, thanks! ❤️

Could you please cherry-pick your commit on the cms_pico-1.0 branch? The master branch is the dev version of cms_pico v2.0. Just switching the PR's base unfortunately doesn't work properly.

However, please note that cms_pico is currently basically abandoned dev-wise, thus there isn't going to be a new release soon. There's currently no stable version of cms_pico supporting any of Nextcloud's still officially supported branches; people still using cms_pico do so at their own risk and use custom app builds based on the cms_pico-1.0 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some files have not passed the integrity check.

6 participants