-
Notifications
You must be signed in to change notification settings - Fork 63
Cookie updated by NetworkToCode Cookie Drift Manager Tool #737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jeffkala
wants to merge
7
commits into
develop
Choose a base branch
from
drift-manager/pr
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
673229a
Cookie updated by NetworkToCode Cookie Drift Manager Tool
jeffkala b5ebd39
Cookie updated by NetworkToCode Cookie Drift Manager Tool
69bc104
address merge conflicts
jeffkala 22218a1
address remaining merge conflicts
jeffkala ff8a65e
relock :annoyed:
jeffkala 2ab10cb
change frag and fix mkdocs
jeffkala 160e1a7
ignore logging from j2 mappings
jeffkala File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| --- | ||
| name: "Release" | ||
| on: # yamllint disable-line rule:truthy rule:comments | ||
| release: | ||
| types: ["published"] | ||
|
|
||
| jobs: | ||
| build: | ||
| name: "Build package with poetry" | ||
| runs-on: "ubuntu-latest" | ||
| if: "startsWith(github.ref, 'refs/tags/v')" | ||
| steps: | ||
| - uses: "actions/checkout@v4" | ||
| - name: "Setup environment" | ||
| uses: "networktocode/gh-action-setup-poetry-environment@v6" | ||
| with: | ||
| poetry-version: "2.1.3" | ||
| python-version: "3.13" | ||
| poetry-install-options: "--no-root" | ||
| - name: "Build Documentation" | ||
| run: "poetry run invoke build-and-check-docs" | ||
| - name: "Run Poetry Build" | ||
| run: "poetry build" | ||
|
|
||
| - name: "Check that the release tag matches the version in pyproject.toml" | ||
| run: | | ||
| if [ "${{ github.ref_name }}" != "v$(poetry version -s)" ]; then exit 1; fi | ||
|
|
||
| - uses: "actions/upload-artifact@v4" | ||
| with: | ||
| name: "distfiles" | ||
| path: "dist/" | ||
| if-no-files-found: "error" | ||
|
|
||
| publish-github: | ||
| name: "Publish to GitHub" | ||
| runs-on: "ubuntu-latest" | ||
| if: "startsWith(github.ref, 'refs/tags/v')" | ||
| permissions: | ||
| contents: "write" | ||
| needs: "build" | ||
| steps: | ||
| - uses: "actions/checkout@v4" | ||
| - name: "Retrieve built package from cache" | ||
| uses: "actions/download-artifact@v4" | ||
| with: | ||
| name: "distfiles" | ||
| path: "dist/" | ||
|
|
||
| - name: "Upload binaries to release" | ||
| run: "gh release upload ${{ github.ref_name }} dist/*.{tar.gz,whl}" | ||
| env: | ||
| GH_TOKEN: "${{ secrets.NTC_GITHUB_TOKEN }}" | ||
|
|
||
| publish-pypi: | ||
| name: "Push Package to PyPI" | ||
| runs-on: "ubuntu-latest" | ||
| if: "startsWith(github.ref, 'refs/tags/v')" | ||
| needs: "build" | ||
| environment: "pypi" | ||
| permissions: | ||
| # IMPORTANT: this permission is mandatory for Trusted Publishing | ||
| id-token: "write" | ||
| steps: | ||
| - name: "Retrieve built package from cache" | ||
| uses: "actions/download-artifact@v4" | ||
| with: | ||
| name: "distfiles" | ||
| path: "dist/" | ||
|
|
||
| - name: "Publish package distributions to PyPI" | ||
| uses: "pypa/gh-action-pypi-publish@ed0c53931b1dc9bd32cbe73a98c7f6766f8a527e" # v1.13.0 | ||
|
|
||
| slack-notify: | ||
| needs: | ||
| - "publish-github" | ||
| - "publish-pypi" | ||
| runs-on: "ubuntu-latest" | ||
| env: | ||
| # Secrets cannot be directly referenced in if: conditionals. They must be set as a job env var first. | ||
| # Ref: https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#example-using-secrets | ||
| SLACK_WEBHOOK_URL: "${{ secrets.OSS_PYPI_SLACK_WEBHOOK_URL }}" | ||
| SLACK_WEBHOOK_TYPE: "INCOMING_WEBHOOK" | ||
| SLACK_MESSAGE: >- | ||
| *NOTIFICATION: NEW-RELEASE-PUBLISHED*\n | ||
| Repository: <${{ github.server_url }}/${{ github.repository }}|${{ github.repository }}>\n | ||
| Release: <${{ github.server_url }}/${{ github.repository }}/releases/tag/${{ github.ref_name }}|${{ github.ref_name }}>\n | ||
| Published by: <${{ github.server_url }}/${{ github.actor }}|${{ github.actor }}> | ||
| steps: | ||
| - name: "Send a notification to Slack" | ||
| if: "${{ env.SLACK_WEBHOOK_URL != '' }}" | ||
| uses: "slackapi/slack-github-action@fcfb566f8b0aab22203f066d80ca1d7e4b5d05b3" # v1.27.1 | ||
| with: | ||
| payload: | | ||
| { | ||
| "text": "${{ env.SLACK_MESSAGE }}", | ||
| "blocks": [ | ||
| { | ||
| "type": "section", | ||
| "text": { | ||
| "type": "mrkdwn", | ||
| "text": "${{ env.SLACK_MESSAGE }}" | ||
| } | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| ARG PYTHON_VER="3.9" | ||
| ARG PYTHON_VER="3.10" | ||
|
|
||
| FROM python:${PYTHON_VER}-slim | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Rebaked from the cookie `main`. |
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I won't hold up.. but i am still of the opinion, we should be using the latest by default, and CI should run the oldest. There are some idiosyncrasies, like I think ruff says to use the oldest version in the config.. but that is just the config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, I'll look again but this specific variable is for the min python version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, but the Dockerfile is using is, e.g.
also, where is the max defined?