CiscoIOSXRConfigParser finding delimiter when banner is at the end of a config #655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julmanglano
requested review from
itdependsnetworks,
jeffkala and
qduk
as code owners
Collaborator
|
Would it make any sense to put the call to |
| compliance.parser_map["cisco_ios"](logging).config_lines # pylint: disable=expression-not-assigned | ||
|
|
||
|
|
||
| def test_banner_delimiter_iosxr(): |
Contributor
There was a problem hiding this comment.
These tests may be good, but hard for me to understand, can you add to a mock test here: https://github.com/networktocode/netutils/tree/develop/tests/unit/mock/config/parser/base/cisco_iosxr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request
Have you:
Change Notes
Added fix for finding banner delimiter when banner is at the end of the config ( IOSXR)
Justification
Closes #614