Allow decimals for tax calculator #227
Open
+91
−95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
/assign @mraerino |
Author
|
@mraerino could you please help review the PR for me? |
Member
|
Hey Jiefeng Xu, thanks for the contribution. As far as I can see this changes all currency calculations to use floats which is an anti pattern when it comes to money: Here's a few article on why this should be avoided: https://husobee.github.io/money/float/2016/09/23/never-use-floats-for-currency.html |
Author
|
Thank you @biilmann. Will read the articles soon. |
|
How about using decimal ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Fixes issue #153 - allow decimals for tax calculator
- Test plan
calculator_test.go
- Description for the changelog
Using float64 instead of uint64 / int64
- A picture of a cute animal (not mandatory but encouraged)