Include user agent sniffing #6783
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascorbic
reviewed
Nov 19, 2025
| installCommand: 'pnpm install', | ||
| runCommand: 'pnpm run', | ||
| localPackageCommand: 'pnpm', | ||
| remotePackageCommand: ['pnpm', 'dlx'], |
Author
There was a problem hiding this comment.
pnpx was deprecated in pnpm v6, I believe, although it still seems to work as an alias
Contributor
There was a problem hiding this comment.
I believe it was un-deprecated. It's no longer documented as such. I guess it's safer to keep as this.
ascorbic
reviewed
Nov 19, 2025
packages/build-info/src/package-managers/detect-package-manager.ts
Outdated
Show resolved
Hide resolved
…r.ts Co-authored-by: Matt Kane <m@mk.gg>
penalosa
force-pushed
the
penalosa/include-user-agent
branch
from
1b495d9 to
a0dd37d
Compare
pieh
reviewed
Dec 1, 2025
| * 3. a lock file that is present in this directory or up in the tree for workspaces | ||
| */ | ||
| export const detectPackageManager = async (project: Project): Promise<PkgManagerFields | null> => { | ||
| const sniffedPkgManager = sniffUserAgent() |
Contributor
There was a problem hiding this comment.
Some of our usage is done on user behalf and in this case sniffing is not desirable, because it would detect what we use and not what user does and might lead to unexpected results.
Given this is new capability - this should be some kind of opt-in, so it doesn't accidentally affect our existing flows while still allowing to opt into it when integrating detection in user initiated flows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds npm user agent sniffing to the package manager detection logic. Previously, package manager detection logic relied on lockfiles, which requires the project to already have been created. Another use case for package manager detection logic is figuring out which package manager ran a creation flow. In that case (e.g.
npm create cloudflarevspnpm create cloudflare) there's no lockfile to go off, and so we need to rely on the user agent.This copies over logic from Wrangler with the intention of removing it in Wrangler entirely and relying on
@netlify/build-info.For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)