-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Closes #18658: Add start on boot field to VirtualMachine model #20751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ine model, fixed identation
|
For reviewers I had doubts about how I would do the displaying of the start on boot status. The 'status' field in the model VirtualMachine uses a badge. I decided to not use a badge but plaintext or a placeholder when the 'start_on_boot' field is empty. This was a personal choice but can be changed ofc. I did specify colors in the choices model for when a badge is preferred. I took inspiration from another merge request that added a status field to some model, so I guess I got everything covered, bulk_imports, csv_imports, etc. I added this to the tests too and they run succesfully. |
arthanson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, just some cleanup needed mostly on the color and merge the migrations together.
| @@ -0,0 +1,18 @@ | |||
| # Generated by Django 5.2.7 on 2025-11-05 13:45 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These migrations should be collapsed together
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this migration, like you said in another feedback item there isn't really a case where the field should be empty. There is always some kind of behaviour when the hypervisor reboots
… fixed inconsistent diplay of start_on_boot
arthanson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @RobertH1993 !
Closes: #18658
Adds start on boot field to VirtualMachine model