Skip to content

Add positions property for node collection #3595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add positions property for node collection #3595

wants to merge 5 commits into from

Conversation

@babsey
Copy link
Contributor

@babsey babsey commented Oct 8, 2025

It is an enhancement to get positions from node collection.

heplesser
heplesser requested changes Oct 8, 2025
View reviewed changes
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@babsey Thanks! Please see my inline comment.

@heplesser heplesser added T: Enhancement New functionality, model or documentation S: Normal Handle this with default priority I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Oct 8, 2025
@heplesser heplesser added this to PyNEST Oct 8, 2025
@github-project-automation github-project-automation bot moved this to In progress in PyNEST Oct 8, 2025
babsey and others added 2 commits October 8, 2025 10:23
@babsey @heplesser
Update pynest/nest/lib/hl_api_types.py
6c27f5a 
Co-authored-by: Hans Ekkehard Plesser <hans.ekkehard.plesser@nmbu.no>
@babsey
Remove exception
f26ba34
heplesser
heplesser requested changes Nov 24, 2025
View reviewed changes
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@babsey Here a suggestion to make this PR user- and PyNEST-NG-safe.

But is also makes me wonder if you really need this, or if you couldn't just use node_coll.spatial['positions'] directly in NEST Server?

@github-project-automation github-project-automation bot moved this from In progress to Review in PyNEST Nov 24, 2025
@babsey @heplesser
Update pynest/nest/lib/hl_api_types.py
3c998b2 
Co-authored-by: Hans Ekkehard Plesser <hans.ekkehard.plesser@nmbu.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@heplesser heplesser heplesser requested changes

@jessica-mitchell jessica-mitchell Awaiting requested review from jessica-mitchell

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation

Projects

PyNEST
Status: Review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@babsey @heplesser