neo4j · angrykoala · Nov 25, 2025 · Oct 13, 2025 · Oct 14, 2025 · Oct 15, 2025
diff --git a/.changeset/good-wombats-live.md b/.changeset/good-wombats-live.md
@@ -0,0 +1,5 @@
+---
+"@neo4j/graphql": patch
+---
+
+Fix duplicate relationships on nested connect from union types
diff --git a/docs/contributing/DEVELOPING.md b/docs/contributing/DEVELOPING.md
@@ -56,9 +56,9 @@ yarn install
 [Visual Studio Code](https://code.visualstudio.com/) comes highly recommended
 for working in this repository, and we additionally recommend the following extensions:
 
-* [ESLint](https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint)
-* [Jest](https://marketplace.visualstudio.com/items?itemName=Orta.vscode-jest)
-* [Prettier](https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode)
+- [ESLint](https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint)
+- [Jest](https://marketplace.visualstudio.com/items?itemName=Orta.vscode-jest)
+- [Prettier](https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode)
 
 The Jest extension should automatically detect the tests for this repository and
 watch them in the Status Bar.
@@ -69,16 +69,16 @@ In some cases, it may be worth testing `@neo4j/graphql` with a local version of
 
 In the Cypher Builder folder run:
 
-* `yarn link`
-* `yarn build` - This step needs to be done each time a change is done in the Cypher Builder
+- `yarn link`
+- `yarn build` - This step needs to be done each time a change is done in the Cypher Builder
 
 In the root of the `neo4j/graphql` monorepo run:
 
-* `yarn link -p [path-to-local-cypher-builder]
+- `yarn link -p [path-to-local-cypher-builder]
 
 To unlink, in the graphql project:
 
-* `yarn unlink @neo4j/cypher-builder`
+- `yarn unlink @neo4j/cypher-builder`
 
 ## Testing
 
@@ -135,7 +135,7 @@ yarn test:tck
 You can run all the TCK tests against the database to check that the Cypher generated is valid. This can be done with the env variable `VERIFY_TCK`
 
 ```bash
-VERIFY_TCK yarn test:tck
+VERIFY_TCK=true yarn test:tck
 ```
 
 ### Testing using docker
@@ -228,8 +228,8 @@ adhere to our linting and formatting rules.
 For the sake of completeness, add an entry for the new project into the following
 files in the root of the repository:
 
-* `tsconfig.json` (`references` entry)
-* `jest.config.base.js` (`moduleNameMapper` entry)
+- `tsconfig.json` (`references` entry)
+- `jest.config.base.js` (`moduleNameMapper` entry)
 
 ### Dependencies within the monorepo
 
@@ -268,10 +268,10 @@ like:
 
 The real key entries here are:
 
-* `baseUrl` - for all of the relative references in this file, this will tell
-    `tsc` where to start from
-* `paths` - this will translate `import` statements in code to the relative dependency
-* `references` - gives TypeScript "permission" to accesss the projects at these paths
+- `baseUrl` - for all of the relative references in this file, this will tell
+  `tsc` where to start from
+- `paths` - this will translate `import` statements in code to the relative dependency
+- `references` - gives TypeScript "permission" to accesss the projects at these paths
 
 Finally, it is highly likely that Jest will also need access to this internal
 dependency, so `packages/project/jest.config.js` will need to look like:

diff --git a/packages/graphql/src/classes/CallbackBucketDeprecated.ts b/packages/graphql/src/classes/CallbackBucketDeprecated.ts
diff --git a/packages/graphql/src/classes/GraphElement.ts b/packages/graphql/src/classes/GraphElement.ts
@@ -18,14 +18,14 @@
  */
 
 import type {
-    CypherField,
-    PrimitiveField,
+    BaseField,
     CustomEnumField,
+    CustomResolverField,
     CustomScalarField,
-    TemporalField,
+    CypherField,
     PointField,
-    CustomResolverField,
-    BaseField,
+    PrimitiveField,
+    TemporalField,
 } from "../types";
 
 export interface GraphElementConstructor {
@@ -40,6 +40,7 @@ export interface GraphElementConstructor {
     customResolverFields: CustomResolverField[];
 }
 
+/** @deprecated */
 export abstract class GraphElement {
     public name: string;
     public description?: string;

diff --git a/packages/graphql/src/classes/Node.ts b/packages/graphql/src/classes/Node.ts
@@ -109,6 +109,7 @@ export type SubscriptionEvents = {
     delete_relationship: string;
 };
 
+/** @deprecated */
 class Node extends GraphElement {
     public relationFields: RelationField[];
     public connectionFields: ConnectionField[];

diff --git a/packages/graphql/src/classes/Relationship.ts b/packages/graphql/src/classes/Relationship.ts
@@ -45,7 +45,7 @@ interface RelationshipConstructor {
     pointFields?: PointField[];
     customResolverFields?: CustomResolverField[];
 }
-
+/** @deprecated */
 class Relationship extends GraphElement {
     public properties?: string;
     public source: string;

diff --git a/packages/graphql/src/schema-model/relationship/model-adapters/RelationshipAdapter.ts b/packages/graphql/src/schema-model/relationship/model-adapters/RelationshipAdapter.ts
@@ -138,10 +138,8 @@ export class RelationshipAdapter {
     public findAttribute(name: string): AttributeAdapter | undefined {
         return this.attributes.get(name);
     }
+
     /**
-     * translation-only
-     *
-     * @param directed the direction asked during the query, for instance "friends(directed: true)"
      * @returns the direction to use in the CypherBuilder
      **/
     public getCypherDirection(): "left" | "right" | "undirected" {

diff --git a/packages/graphql/src/schema/resolvers/mutation/create.ts b/packages/graphql/src/schema/resolvers/mutation/create.ts
@@ -20,7 +20,7 @@
 import { Kind, type FieldNode, type GraphQLResolveInfo } from "graphql";
 import type { Node } from "../../../classes";
 import type { ConcreteEntityAdapter } from "../../../schema-model/entity/model-adapters/ConcreteEntityAdapter";
-import { translateCreate } from "../../../translate";
+import { translateCreate } from "../../../translate/translate-create";
 import type { Neo4jGraphQLTranslationContext } from "../../../types/neo4j-graphql-translation-context";
 import { execute } from "../../../utils";
 import getNeo4jResolveTree from "../../../utils/get-neo4j-resolve-tree";

diff --git a/packages/graphql/src/schema/resolvers/mutation/delete.ts b/packages/graphql/src/schema/resolvers/mutation/delete.ts
@@ -20,7 +20,7 @@
 import type { GraphQLResolveInfo } from "graphql";
 import type { SchemaComposer } from "graphql-compose";
 import type { ConcreteEntityAdapter } from "../../../schema-model/entity/model-adapters/ConcreteEntityAdapter";
-import { translateDelete } from "../../../translate";
+import { translateDelete } from "../../../translate/translate-delete";
 import type { Neo4jGraphQLTranslationContext } from "../../../types/neo4j-graphql-translation-context";
 import { execute } from "../../../utils";
 import getNeo4jResolveTree from "../../../utils/get-neo4j-resolve-tree";

diff --git a/packages/graphql/src/schema/resolvers/mutation/update.ts b/packages/graphql/src/schema/resolvers/mutation/update.ts
@@ -24,7 +24,9 @@ import type {
 } from "graphql-compose";
 import type { Node } from "../../../classes";
 import type { ConcreteEntityAdapter } from "../../../schema-model/entity/model-adapters/ConcreteEntityAdapter";
-import { translateUpdate } from "../../../translate";
+import { QueryASTFactory } from "../../../translate/queryAST/factory/QueryASTFactory";
+import { CallbackBucket } from "../../../translate/queryAST/utils/callback-bucket";
+import { buildClause } from "../../../translate/utils/build-clause";
 import type { Neo4jGraphQLTranslationContext } from "../../../types/neo4j-graphql-translation-context";
 import { execute } from "../../../utils";
 import getNeo4jResolveTree from "../../../utils/get-neo4j-resolve-tree";
@@ -42,7 +44,10 @@ export function updateResolver({
 
         (context as Neo4jGraphQLTranslationContext).resolveTree = resolveTree;
 
-        const [cypher, params] = await translateUpdate({ context: context as Neo4jGraphQLTranslationContext, node });
+        const { cypher, params } = await translateUpdate({
+            context: context as Neo4jGraphQLTranslationContext,
+            nodeName: node.name,
+        });
         const executeResult = await execute({
             cypher,
             params,
@@ -52,8 +57,9 @@ export function updateResolver({
         });
 
         const nodeProjection = info.fieldNodes[0]?.selectionSet?.selections.find(
-            (selection): selection is FieldNode =>
-                selection.kind === Kind.FIELD && selection.name.value === concreteEntityAdapter.plural
+            (selection): selection is FieldNode => {
+                return selection.kind === Kind.FIELD && selection.name.value === concreteEntityAdapter.plural;
+            }
         );
 
         const resolveResult = {
@@ -64,7 +70,7 @@ export function updateResolver({
 
         if (nodeProjection) {
             const nodeKey = nodeProjection.alias ? nodeProjection.alias.value : nodeProjection.name.value;
-            resolveResult[nodeKey] = executeResult.records[0]?.data || [];
+            resolveResult[nodeKey] = executeResult.records.map((x) => x.this);
         }
 
         return resolveResult;
@@ -82,3 +88,34 @@ export function updateResolver({
         },
     };
 }
+
+async function translateUpdate({
+    context,
+    nodeName,
+}: {
+    context: Neo4jGraphQLTranslationContext;
+    nodeName: string;
+}): Promise<{ cypher: string; params: Record<string, any> }> {
+    const { resolveTree } = context;
+    const entityAdapter = context.schemaModel.getConcreteEntityAdapter(nodeName);
+    if (!entityAdapter) {
+        throw new Error(`Transpilation error: ${nodeName} is not a concrete entity`);
+    }
+
+    const varName = "this";
+    const operationsTreeFactory = new QueryASTFactory(context.schemaModel);
+    const callbackBucket = new CallbackBucket(context);
+
+    const operationsTree = operationsTreeFactory.createMutationAST({
+        resolveTree,
+        entityAdapter,
+        context,
+        varName,
+        callbackBucket,
+    });
+
+    await callbackBucket.resolveCallbacks();
+
+    const clause = operationsTree.build(context, varName);
+    return buildClause(clause, { context });
+}
diff --git a/packages/graphql/src/schema/resolvers/query/cypher.ts b/packages/graphql/src/schema/resolvers/query/cypher.ts
@@ -19,7 +19,7 @@
 
 import type { GraphQLResolveInfo } from "graphql";
 import type { AttributeAdapter } from "../../../schema-model/attribute/model-adapters/AttributeAdapter";
-import { translateTopLevelCypher } from "../../../translate";
+import { translateTopLevelCypher } from "../../../translate/translate-top-level-cypher";
 import type { CypherField } from "../../../types";
 import type { Neo4jGraphQLTranslationContext } from "../../../types/neo4j-graphql-translation-context";
 import { execute } from "../../../utils";

diff --git a/packages/graphql/src/schema/resolvers/query/fulltext.ts b/packages/graphql/src/schema/resolvers/query/fulltext.ts
@@ -20,7 +20,7 @@
 import type { GraphQLFieldResolver, GraphQLResolveInfo, SelectionSetNode } from "graphql";
 import type { ConcreteEntityAdapter } from "../../../schema-model/entity/model-adapters/ConcreteEntityAdapter";
 import type { InterfaceEntityAdapter } from "../../../schema-model/entity/model-adapters/InterfaceEntityAdapter";
-import { translateRead } from "../../../translate";
+import { translateRead } from "../../../translate/translate-read";
 import type { FulltextContext } from "../../../types";
 import { execute } from "../../../utils";
 import getNeo4jResolveTree from "../../../utils/get-neo4j-resolve-tree";