Skip to content

MMT-4038: Fix issue where one input was affecting another on the form #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 10, 2025
Merged

MMT-4038: Fix issue where one input was affecting another on the form #1423

Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5e305d5
MMT-4083: Increased lengh of pref label and alt label to 1024
Oct 8, 2025
02b06c2
MMT-4038: Added missing Aggregation field into UI schema.
Oct 21, 2025
d2bb7ad
Merge branch 'main' into MMT-4038
Oct 21, 2025
bd0a024
MMT-4083: Updated based on PR feedback.
Oct 24, 2025
66068af
MMT-4038: Removed redundant Aggregation
Oct 24, 2025
9a6c769
MMT-4038: Updated to latest edsc preview.
Oct 28, 2025
ef168a4
MMT-4038: Fixed issue when toggling radio button to true/false.
Nov 7, 2025
eb65bda
Merge branch 'main' into MMT-4038
Nov 7, 2025
745d5b2
MMT-4038: Added comment about name properties needing to be unique
Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions static/src/js/components/CustomRadioWidget/CustomRadioWidget.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,8 @@ const CustomRadioWidget = ({

// Sets inputValue to input selected
const handleChange = (event) => {
const { name } = event.target
const newValue = name === 'true'

const { id: targetId } = event.target
const newValue = targetId.endsWith('-true')
onChange(newValue)
}

Expand Down Expand Up @@ -100,7 +99,7 @@ const CustomRadioWidget = ({
<input
className="d-flex form-check-input m-2"
id={`${id}-true`}
Copy link
Contributor

@eudoroolivares2016 eudoroolivares2016 Nov 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the id values duplicates? I'm kind of confused why the name would be used here or contain the id value since the name should be what is on the view/display. If its on the same widget since that's the prop coming from the parent maybe we can append another part to the id value in each of the inputs or pass down a little more information where this gets rendered from

Copy link
Collaborator Author

@cgokey cgokey Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afaik this is being required by react-json-schema form, otherwise the form itself gets out of sync with the json data.

name="true"
name={`${id}-true`}
Copy link
Contributor

@mandyparson mandyparson Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can just be name={id}

Copy link
Collaborator Author

@cgokey cgokey Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we need to tack on -true to be make it unique.

onChange={handleChange}
type="radio"
checked={value === true}
Expand All @@ -115,7 +114,7 @@ const CustomRadioWidget = ({
<input
className="form-check-input m-2"
id={`${id}-false`}
name="false"
name={`${id}-false`}
Copy link
Contributor

@mandyparson mandyparson Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Collaborator Author

@cgokey cgokey Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to tack on -false to make it unique.

onChange={handleChange}
type="radio"
checked={value === false}
Expand Down