Overhaul partition handling #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
November 22, 2025 21:27
Alek96
approved these changes
Nov 24, 2025
Alek96
left a comment
Alek96
left a comment
There was a problem hiding this comment.
I’ve added a few comments, but they’re mostly related to my personal coding style. Overall, it’s a +1 from me.
namastack-outbox-core/src/main/kotlin/io/namastack/outbox/OutboxProcessingScheduler.kt
Outdated
Show resolved
Hide resolved
namastack-outbox-core/src/main/kotlin/io/namastack/outbox/partition/NewInstancesRebalancer.kt
Outdated
Show resolved
Hide resolved
namastack-outbox-core/src/main/kotlin/io/namastack/outbox/partition/NewInstancesRebalancer.kt
Outdated
Show resolved
Hide resolved
namastack-outbox-core/src/main/kotlin/io/namastack/outbox/partition/NewInstancesRebalancer.kt
Outdated
Show resolved
Hide resolved
...k-outbox-core/src/main/kotlin/io/namastack/outbox/partition/PartitionAssignmentRepository.kt
Outdated
Show resolved
Hide resolved
namastack-outbox-core/src/main/kotlin/io/namastack/outbox/partition/PartitionCoordinator.kt
Outdated
Show resolved
Hide resolved
...stack-outbox-core/src/main/kotlin/io/namastack/outbox/partition/StalePartitionsRebalancer.kt
Outdated
Show resolved
Hide resolved
...stack-outbox-core/src/main/kotlin/io/namastack/outbox/partition/StalePartitionsRebalancer.kt
Outdated
Show resolved
Hide resolved
...stack-outbox-core/src/main/kotlin/io/namastack/outbox/partition/StalePartitionsRebalancer.kt
Outdated
Show resolved
Hide resolved
...ack-outbox-jpa/src/main/kotlin/io/namastack/outbox/JpaOutboxPartitionAssignmentRepository.kt
Outdated
Show resolved
Hide resolved
added 2 commits
November 24, 2025 22:39
…skExecutors for heartbeat and rebalancing
Collaborator
Author
Hey @Alek96, thanks again for reviewing my code! I’ve done some overall refactoring, and I’d be really happy if you could find a moment to look over the changes. Hopefully most of the points from your last review are also addressed now. |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Alek96
approved these changes
Nov 26, 2025
...ack-outbox-jpa/src/main/kotlin/io/namastack/outbox/JpaOutboxPartitionAssignmentRepository.kt
Outdated
Show resolved
Hide resolved
added 2 commits
November 26, 2025 22:51
…and add some tests
…ExceptionHelper messages in log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.