Skip to content

Backport make CometBFT max_tx_bytes configurable #4985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Backport make CometBFT max_tx_bytes configurable #4985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1a2885
make CometBFT max_tx_bytes configurable
yito88 Jun 25, 2025
25e5550
revert comment
yito88 Jun 25, 2025
ddf6564
changelog
yito88 Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changelog/unreleased/miscellaneous/4712-comet-max-tx-size.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Make CometBFT max_tx_bytes configurable
([\#4712](https://github.com/anoma/namada/issues/4712))
2 changes: 1 addition & 1 deletion crates/node/src/tendermint_node.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ async fn update_tendermint_config(
// 1 MiB is a reasonable value that allows governance proposal txs
// containing wasm code to be proposed by a leading validator
// during some round's start
config.mempool.max_tx_bytes = 1024 * 1024;
// https://github.com/cometbft/cometbft/blob/c653eee08d7f2c44bd87fcca0b8a16666cd08fee/config/config.go#L1016

// Hold 50x the max amount of txs in a block.
#[allow(clippy::arithmetic_side_effects)]
Expand Down
Loading