Skip to content

Conversation

@batconjurer
Copy link
Collaborator

Describe your changes

Closes #4716

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@github-actions github-actions bot added the breaking:api public API breaking change label Jul 8, 2025
@batconjurer batconjurer requested review from grarco, murisi, sug0 and tzemanovic and removed request for sug0 July 14, 2025 08:21
@batconjurer batconjurer added breaking:cli command line breaking change breaking:client Namada client breaking change breaking:consensus Consensus breaking change that requires a hard-fork breaking: tx Transaction format breaking change breaking:state State breaking change that is not backwards compatible with a state recorded by current version breaking:SDK SDK breaking change labels Jul 14, 2025
Co-authored-by: Tomas Zemanovic <tomas@heliax.dev>
@batconjurer batconjurer mentioned this pull request Jul 14, 2025
6 tasks
@batconjurer batconjurer changed the title Adding a shielding fee for normal shielding txs. Still need to check IBC Adding a shielding fee for normal shielding txs. Jul 16, 2025
Copy link
Collaborator

@sug0 sug0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall this is correct, in terms of impl alone. we should check in with @cwgoes that this meets the desired design principles. also, should pitch in some opinion from @murisi about the hw wallet changes required

@batconjurer batconjurer force-pushed the bat/add-shielding-fee-section branch from 9f91824 to 41cda8f Compare July 25, 2025 14:09
@batconjurer batconjurer requested review from grarco, sug0 and yito88 and removed request for murisi July 28, 2025 09:41
@brentstone
Copy link
Collaborator

Let's get some new reviews here

@brentstone
Copy link
Collaborator

Just want to note that the fee must only be taken if the associated tx is successful @sug0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking:api public API breaking change breaking:cli command line breaking change breaking:client Namada client breaking change breaking:consensus Consensus breaking change that requires a hard-fork breaking:SDK SDK breaking change breaking:state State breaking change that is not backwards compatible with a state recorded by current version breaking: tx Transaction format breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add fees for shielding to the MASP

6 participants