-
Notifications
You must be signed in to change notification settings - Fork 1k
Adding a shielding fee for normal shielding txs. #4726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
batconjurer
wants to merge
25
commits into
main
Choose a base branch
from
bat/add-shielding-fee-section
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
reviewed
Jul 14, 2025
Co-authored-by: Tomas Zemanovic <tomas@heliax.dev>
grarco
reviewed
Jul 14, 2025
grarco
reviewed
Jul 14, 2025
grarco
reviewed
Jul 14, 2025
grarco
reviewed
Jul 14, 2025
grarco
reviewed
Jul 15, 2025
grarco
reviewed
Jul 15, 2025
sug0
approved these changes
Jul 17, 2025
Collaborator
sug0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grarco
approved these changes
Jul 17, 2025
9f91824 to
41cda8f
Compare
Collaborator
|
Let's get some new reviews here |
3 tasks
3 tasks
Collaborator
|
Just want to note that the fee must only be taken if the associated tx is successful @sug0 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking:api
public API breaking change
breaking:cli
command line breaking change
breaking:client
Namada client breaking change
breaking:consensus
Consensus breaking change that requires a hard-fork
breaking:SDK
SDK breaking change
breaking:state
State breaking change that is not backwards compatible with a state recorded by current version
breaking: tx
Transaction format breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #4716
Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo