add ability to query specific txn types in /v1/chain/history #361
+106
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fraccaman
force-pushed
the
feat/add-transsaction-history-types
branch
from
e7a3a6e to
66a3f6e
Compare
grarco
reviewed
Jun 13, 2025
| "unjailValidator" => { | ||
| Some(TransactionKindDb::UnjailValidator) | ||
| } | ||
| _ => None, // Skip invalid types |
Contributor
There was a problem hiding this comment.
Better to return an error maybe? To avoid typos going unnoticed
grarco
reviewed
Jun 13, 2025
| #[validate(length(min = 1, max = 10))] | ||
| pub addresses: Vec<String>, | ||
| #[validate(length(min = 1, max = 20))] | ||
| pub transaction_types: Option<HashSet<String>>, |
Contributor
There was a problem hiding this comment.
We could also just have an empty set without the need for an Option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.