feat: add --jobs flag to limit concurrent file imports #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran into a scenario on shared hosting where isolation is only by Linux user. Process sees all 64 CPUs but you shouldn't actually use them all since other users share the same server. Added `-j/--jobs` flag to set number of parallel jobs during import. Still uses num_cpus::get() if flag not provided to maintain existing behavior. Use lower value on shared infrastructure to avoid impacting other users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into a scenario on shared hosting where isolation is only by Linux user. Process sees all 64 CPUs but you shouldn't actually use them all since other users share the same server.
Added
-j/--jobsflag to set number of parallel jobs during import. Still uses num_cpus::get() if flag not provided to maintain existing behavior. Use lower value on shared infrastructure to avoid impacting other users.