Skip to content

Add linklocal4 addresses to regular addresses #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add linklocal4 addresses to regular addresses #50

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c1a3569
Include IPv4 link-local addresses in the regular field
zh522130 Oct 15, 2025
09d215a
use chain to combine extend operations
zh522130 Oct 16, 2025
5f367fe
update comments
zh522130 Oct 16, 2025
741c4e8
Merge branch 'n0-computer:main' into add-linklocal4-to-regular
zh522130 Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions netwatch/src/ip.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ impl Default for LocalAddresses {
#[cfg(not(wasm_browser))]
impl LocalAddresses {
/// Returns the machine's IP addresses.
/// If there are no regular addresses it will return any IPv4 linklocal or IPv6 unique local
/// addresses because we know of environments where these are used with NAT to provide connectivity.
/// Regular includes all non-loopback IPv4 (including link-local).
/// IPv6 link-local and unique local are excluded from regular.
pub fn new() -> Self {
let ifaces = netdev::interface::get_interfaces();
Self::from_raw_interfaces(&ifaces)
Expand Down Expand Up @@ -83,16 +83,8 @@ impl LocalAddresses {
}
}

if regular4.is_empty() && regular6.is_empty() {
// if we have no usable IP addresses then be willing to accept
// addresses we otherwise wouldn't, like:
// + 169.254.x.x (AWS Lambda uses NAT with these)
// + IPv6 ULA (Google Cloud Run uses these with address translation)
regular4 = linklocal4;
regular6 = ula6;
}
let mut regular = regular4;
regular.extend(regular6);
regular.extend(linklocal4.into_iter().chain(regular6));

regular.sort();
loopback.sort();
Expand Down