feat: Do not force relay URLs to be absolute #3623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is really up to the user. Forcing this was always a choice that made me slightly uncomfortable. Some weird places might need relative URLs. Or places that need to be able to use this same URL using OpenSSL, which has a bug handling certificates that do not have the absolute DNS name. The important part is that our defaults still use an absolute DNS name. And we also strongly encourage it. Fixes #3612
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3623/docs/iroh/ Last updated: 2025-11-07T16:48:12Z |
dignifiedquire
approved these changes
Nov 7, 2025
Contributor
dignifiedquire
left a comment
dignifiedquire
left a comment
There was a problem hiding this comment.
I think this makes sense, if folks want to use this they can, but we shouldn't force them
Frando
approved these changes
Nov 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is really up to the user. Forcing this was always a choice that
made me slightly uncomfortable. Some weird places might need relative
URLs. Or places that need to be able to use this same URL using
OpenSSL, which has a bug handling certificates that do not have the
absolute DNS name.
The important part is that our defaults still use an absolute DNS
name. And we also strongly encourage it.
Breaking Changes
None
Notes & open questions
Fixes #3612, obsoletes #3487.
Change checklist