Skip to content

Conversation

@Frando
Copy link
Member

@Frando Frando commented Nov 6, 2025

Description

This allows to do AcceptError::from_boxed(anyhow_err.into_boxed_dyn_error())

Breaking Changes

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.
    • List all breaking changes in the above "Breaking Changes" section.
    • Open an issue or PR on any number0 repos that are affected by this breaking change. Give guidance on how the updates should be handled or do the actual updates themselves. The major ones are:

Copy link
Member

@ramfox ramfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful 😂

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3620/docs/iroh/

Last updated: 2025-11-06T22:54:06Z

@Frando Frando marked this pull request as ready for review November 6, 2025 22:51
@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: aba657f

@n0bot n0bot bot added this to iroh Nov 6, 2025
@github-project-automation github-project-automation bot moved this to 🏗 In progress in iroh Nov 6, 2025
@ramfox ramfox added this to the v0.96 milestone Nov 7, 2025
@Frando Frando added this pull request to the merge queue Nov 11, 2025
github-merge-queue bot pushed a commit that referenced this pull request Nov 11, 2025
## Description

This allows to do
`AcceptError::from_boxed(anyhow_err.into_boxed_dyn_error())`

## Breaking Changes

<!-- Optional, if there are any breaking changes document them,
including how to migrate older code. -->

## Notes & open questions

<!-- Any notes, remarks or open questions you have to make about the PR.
-->

## Change checklist
<!-- Remove any that are not relevant. -->
- [ ] Self-review.
- [ ] Documentation updates following the [style
guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text),
if relevant.
- [ ] Tests if relevant.
- [ ] All breaking changes documented.
- [ ] List all breaking changes in the above "Breaking Changes" section.
- [ ] Open an issue or PR on any number0 repos that are affected by this
breaking change. Give guidance on how the updates should be handled or
do the actual updates themselves. The major ones are:
    - [ ] [`quic-rpc`](https://github.com/n0-computer/quic-rpc)
    - [ ] [`iroh-gossip`](https://github.com/n0-computer/iroh-gossip)
    - [ ] [`iroh-blobs`](https://github.com/n0-computer/iroh-blobs)
    - [ ] [`dumbpipe`](https://github.com/n0-computer/dumbpipe)
    - [ ] [`sendme`](https://github.com/n0-computer/sendme)
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 11, 2025
@Frando Frando added this pull request to the merge queue Nov 11, 2025
Merged via the queue into main with commit 280cfc6 Nov 11, 2025
53 of 54 checks passed
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in iroh Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants