-
Notifications
You must be signed in to change notification settings - Fork 21
fix(wasm): use n0_future for all time::{Instant, Duration} references #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -127,7 +127,6 @@ impl From<irpc::Error> for ExportBaoError { | |
| irpc::Error::OneshotRecv { source, .. } => OneshotRecvSnafu.into_error(source), | ||
| irpc::Error::Send { source, .. } => SendSnafu.into_error(source), | ||
| irpc::Error::Request { source, .. } => RequestSnafu.into_error(source), | ||
| #[cfg(feature = "rpc")] | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this needs to stay
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it's the reason for the CI fails. We might want to fix this in irpc because it's a bit footgunny: The |
||
| irpc::Error::Write { source, .. } => ExportBaoIoSnafu.into_error(source.into()), | ||
| } | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to remember to replace this with an actual dependency before merging.