feat(tags api)!: return number of tags removed by delete operations #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-blobs/pr/178/docs/iroh_blobs/ Last updated: 2025-10-06T12:51:40Z |
rklaehn
reviewed
Oct 6, 2025
src/store/gc.rs
Outdated
| @@ -0,0 +1,472 @@ | |||
| use std::{collections::HashSet, pin::Pin, sync::Arc}; | |||
Collaborator
There was a problem hiding this comment.
This has nothing to do with the PR, right?
Copies gc from fs to store top level. Probably related to something else?
rklaehn
reviewed
Oct 6, 2025
Collaborator
rklaehn
left a comment
rklaehn
left a comment
There was a problem hiding this comment.
Good improvement.
Seems pretty straightforward except for the new gc.rs file that is probably? unrelated to this PR.
rklaehn
approved these changes
Oct 6, 2025
Collaborator
rklaehn
left a comment
rklaehn
left a comment
There was a problem hiding this comment.
I can see that the gc.rs file was a stray from another PR. Removed it.
Collaborator
|
cargo deny is just git deps! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's a huge footgun to silently return
Ok(()), even when no tags are actually removed. Returning the number of tags removed. Also adds documentation calling out this behaviour.Breaking Changes
breaks the return value of the tags API
Notes & open questions
Should we do this with rename, and other mutating operations?
Change checklist