fix: make generate-ticket create ID-only tickets #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flub
reviewed
Oct 25, 2025
Contributor
flub
left a comment
flub
left a comment
There was a problem hiding this comment.
Did you test this works correctly with git-annex and you can still connect?
Contributor
Author
|
I did a basic test between my laptop and a HPC login node at FZJ, and apparently it just works(TM) with the id-only tickets. I think dumbpipe indeed uses the N0 presets and will therefore use the same discovery mechanism on both sides. |
matrss
force-pushed
the
id-only-tickets
branch
from
8d34c41 to
4c11f7a
Compare
flub
approved these changes
Oct 25, 2025
ramfox
pushed a commit
that referenced
this pull request
Nov 6, 2025
Co-authored-by: Matthias Riße <matrss@0px.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #86, see #86 (comment) also.
I am not sure if I should strip out the args entirely again, because they are fully unused. But they are still called "common", so maybe not.