Checks for invalid SQL during the render phase

Author: jeffgbutler

src/main/java/org/mybatis/dynamic/sql/insert/render/GeneralInsertRenderer.java

@@ -1,5 +1,5 @@
 /*
- *    Copyright 2016-2020 the original author or authors.
+ *    Copyright 2016-2022 the original author or authors.
  *
  *    Licensed under the Apache License, Version 2.0 (the "License");
  *    you may not use this file except in compliance with the License.
@@ -24,6 +24,7 @@
 import java.util.Optional;
 import java.util.stream.Collectors;
 
+import org.mybatis.dynamic.sql.exception.InvalidSqlException;
 import org.mybatis.dynamic.sql.insert.GeneralInsertModel;
 import org.mybatis.dynamic.sql.render.RenderingStrategy;
 
@@ -42,6 +43,11 @@ public GeneralInsertStatementProvider render() {
         List<Optional<FieldAndValueAndParameters>> fieldsAndValues = model.mapColumnMappings(m -> m.accept(visitor))
                 .collect(Collectors.toList());
 
+        if(fieldsAndValues.stream().noneMatch(Optional::isPresent)) {
+            throw new InvalidSqlException(
+                    "All optional set phrases were dropped when rendering the general insert statement");
+        }
+
         return DefaultGeneralInsertStatementProvider.withInsertStatement(calculateInsertStatement(fieldsAndValues))
                 .withParameters(calculateParameters(fieldsAndValues))
                 .build();

src/main/java/org/mybatis/dynamic/sql/insert/render/InsertRenderer.java

@@ -1,5 +1,5 @@
 /*
- *    Copyright 2016-2021 the original author or authors.
+ *    Copyright 2016-2022 the original author or authors.
  *
  *    Licensed under the Apache License, Version 2.0 (the "License");
  *    you may not use this file except in compliance with the License.
@@ -22,6 +22,7 @@
 import java.util.Optional;
 import java.util.stream.Collectors;
 
+import org.mybatis.dynamic.sql.exception.InvalidSqlException;
 import org.mybatis.dynamic.sql.insert.InsertModel;
 import org.mybatis.dynamic.sql.render.RenderingStrategy;
 
@@ -41,6 +42,11 @@ public InsertStatementProvider<T> render() {
         List<Optional<FieldAndValue>> fieldsAndValues = model.mapColumnMappings(m -> m.accept(visitor))
                 .collect(Collectors.toList());
 
+        if (fieldsAndValues.stream().noneMatch(Optional::isPresent)) {
+            throw new InvalidSqlException(
+                    "All optional column mappings were dropped when rendering the insert statement");
+        }
+
         return DefaultInsertStatementProvider.withRow(model.row())
                 .withInsertStatement(calculateInsertStatement(fieldsAndValues))
                 .build();

src/main/java/org/mybatis/dynamic/sql/update/render/UpdateRenderer.java

@@ -26,6 +26,7 @@
 import java.util.stream.Collectors;
 
 import org.mybatis.dynamic.sql.SqlTable;
+import org.mybatis.dynamic.sql.exception.InvalidSqlException;
 import org.mybatis.dynamic.sql.render.ExplicitTableAliasCalculator;
 import org.mybatis.dynamic.sql.render.RenderingStrategy;
 import org.mybatis.dynamic.sql.render.TableAliasCalculator;
@@ -56,6 +57,10 @@ public UpdateStatementProvider render() {
                 updateModel.mapColumnMappings(m -> m.accept(visitor))
                 .collect(Collectors.toList());
 
+        if (fragmentsAndParameters.stream().noneMatch(Optional::isPresent)) {
+            throw new InvalidSqlException("All optional set phrases were dropped when rendering the update statement");
+        }
+
         return updateModel.whereModel()
                 .flatMap(this::renderWhereClause)
                 .map(wc -> renderWithWhereClause(fragmentsAndParameters, wc))

src/test/java/org/mybatis/dynamic/sql/InvalidSQLTest.java

@@ -16,6 +16,9 @@
 package org.mybatis.dynamic.sql;
 
 import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
+import static org.mybatis.dynamic.sql.SqlBuilder.insert;
+import static org.mybatis.dynamic.sql.SqlBuilder.insertInto;
+import static org.mybatis.dynamic.sql.SqlBuilder.update;
 
 import java.util.ArrayList;
 import java.util.Collections;
@@ -28,6 +31,7 @@
 import org.mybatis.dynamic.sql.insert.InsertColumnListModel;
 import org.mybatis.dynamic.sql.insert.InsertModel;
 import org.mybatis.dynamic.sql.insert.MultiRowInsertModel;
+import org.mybatis.dynamic.sql.render.RenderingStrategies;
 import org.mybatis.dynamic.sql.select.GroupByModel;
 import org.mybatis.dynamic.sql.select.OrderByModel;
 import org.mybatis.dynamic.sql.select.QueryExpressionModel;
@@ -40,6 +44,7 @@
 class InvalidSQLTest {
 
     private static final SqlTable person = new SqlTable("person");
+    private static final SqlColumn<Integer> id = person.column("id");
 
     @Test
     void testInvalidGeneralInsertStatement() {
@@ -50,6 +55,17 @@ void testInvalidGeneralInsertStatement() {
                 .withMessage("General insert statements must have at least one column mapping");
     }
 
+    @Test
+    void testInvalidGeneralInsertStatementWhenAllOptionalsAreDropped() {
+        GeneralInsertModel model = insertInto(person)
+                .set(id).toValueWhenPresent((Integer) null)
+                .build();
+
+        assertThatExceptionOfType(InvalidSqlException.class)
+                .isThrownBy(() -> model.render(RenderingStrategies.SPRING_NAMED_PARAMETER))
+                .withMessage("All optional set phrases were dropped when rendering the general insert statement");
+    }
+
     @Test
     void testInvalidInsertStatement() {
         InsertModel.Builder<String> builder = new InsertModel.Builder<String>()
@@ -60,6 +76,20 @@ void testInvalidInsertStatement() {
                 .withMessage("Insert statements must have at least one column mapping");
     }
 
+    @Test
+    void testInvalidInsertStatementWhenAllOptionalsAreDropped() {
+        TestRow testRow = new TestRow();
+
+        InsertModel<TestRow> model = insert(testRow)
+                .into(person)
+                .map(id).toPropertyWhenPresent("id", testRow::getId)
+                .build();
+
+        assertThatExceptionOfType(InvalidSqlException.class)
+                .isThrownBy(() -> model.render(RenderingStrategies.SPRING_NAMED_PARAMETER))
+                .withMessage("All optional column mappings were dropped when rendering the insert statement");
+    }
+
     @Test
     void testInvalidMultipleInsertStatementNoRecords() {
         MultiRowInsertModel.Builder<String> builder = new MultiRowInsertModel.Builder<String>()
@@ -176,4 +206,27 @@ void testInvalidUpdateStatement() {
         assertThatExceptionOfType(InvalidSqlException.class).isThrownBy(builder::build)
                 .withMessage("Update statements must have at least one set phrase");
     }
+
+    @Test
+    void testInvalidUpdateStatementWhenAllOptionalsAreDropped() {
+        UpdateModel model = update(person)
+                .set(id).equalToWhenPresent((Integer) null)
+                .build();
+
+        assertThatExceptionOfType(InvalidSqlException.class)
+                .isThrownBy(() -> model.render(RenderingStrategies.SPRING_NAMED_PARAMETER))
+                .withMessage("All optional set phrases were dropped when rendering the update statement");
+    }
+
+    static class TestRow {
+        private Integer id;
+
+        public Integer getId() {
+            return id;
+        }
+
+        public void setId(Integer id) {
+            this.id = id;
+        }
+    }
 }