Throw exception on property file error rather than logging it

Author: jeffgbutler

src/main/java/org/mybatis/dynamic/sql/configuration/GlobalConfiguration.java

@@ -15,11 +15,11 @@
  */
 package org.mybatis.dynamic.sql.configuration;
 
+import org.mybatis.dynamic.sql.exception.DynamicSqlException;
+
 import java.io.IOException;
 import java.io.InputStream;
 import java.util.Properties;
-import java.util.logging.Level;
-import java.util.logging.Logger;
 
 public class GlobalConfiguration {
     public static final String CONFIGURATION_FILE_PROPERTY = "mybatis-dynamic-sql.configurationFile"; //$NON-NLS-1$
@@ -57,8 +57,7 @@ void loadProperties(InputStream inputStream, String propertyFile) {
         try {
             properties.load(inputStream);
         } catch (IOException e) {
-            Logger logger = Logger.getLogger(GlobalConfiguration.class.getName());
-            logger.log(Level.SEVERE, e, () -> "IOException reading property file \"" + propertyFile + "\"");
+            throw new DynamicSqlException("IOException reading property file \"" + propertyFile + "\"", e);
         }
     }
 

src/main/java/org/mybatis/dynamic/sql/exception/DynamicSqlException.java

@@ -19,4 +19,8 @@ public class DynamicSqlException extends RuntimeException {
     public DynamicSqlException(String message) {
         super(message);
     }
+
+    public DynamicSqlException(String message, Throwable cause) {
+        super(message, cause);
+    }
 }

src/test/java/org/mybatis/dynamic/sql/configuration/GlobalConfigurationTest.java

@@ -16,16 +16,13 @@
 package org.mybatis.dynamic.sql.configuration;
 
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
 
 import java.io.IOException;
 import java.io.InputStream;
-import java.util.ArrayList;
-import java.util.List;
-import java.util.logging.Handler;
-import java.util.logging.LogRecord;
-import java.util.logging.Logger;
 
 import org.junit.jupiter.api.Test;
+import org.mybatis.dynamic.sql.exception.DynamicSqlException;
 
 class GlobalConfigurationTest {
     @Test
@@ -62,35 +59,8 @@ void testBadPropertyFile() throws IOException {
         assert inputStream != null;
         inputStream.close();
 
-        TestLogHandler testLogHandler = new TestLogHandler();
-        Logger logger = Logger.getLogger(GlobalConfiguration.class.getName());
-        // we only want to use our handler for this test, so we don't pollute the test output
-        logger.setUseParentHandlers(false);
-        logger.addHandler(testLogHandler);
-
-        configuration.loadProperties(inputStream, "empty.properties");
-        assertThat(testLogHandler.records).hasSize(1);
-        assertThat(testLogHandler.getRecords().get(0).getMessage())
-                .isEqualTo("IOException reading property file \"empty.properties\"");
-    }
-
-    public static class TestLogHandler extends Handler {
-
-        private final List<LogRecord> records = new ArrayList<>();
-
-        public List<LogRecord> getRecords() {
-            return records;
-        }
-
-        @Override
-        public void publish(LogRecord record) {
-            records.add(record);
-        }
-
-        @Override
-        public void flush() {}
-
-        @Override
-        public void close() {}
+        assertThatExceptionOfType(DynamicSqlException.class)
+                .isThrownBy(() -> configuration.loadProperties(inputStream, "empty.properties"))
+                .withMessage("IOException reading property file \"empty.properties\"");
     }
 }