Refined MDP for RL #449
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,9 +32,12 @@ dependencies = [ | |
| "mqt.bench>=2.0.0", | ||
| "qiskit>=1.3.3", | ||
| "pytket>=1.29.0", # lowest version that supports the used pytket AutoRebase pass instead of auto_rebase | ||
| "pytket_qiskit>=0.71.0", | ||
| # TODO(denialhaag): Remove once pytket_qiskit is updated | ||
| # https://github.com/munich-quantum-toolkit/predictor/issues/471 | ||
| "qiskit-ibm-runtime>=0.30.0,<0.42.0", | ||
|
Comment on lines
+36
to
+38
There was a problem hiding this comment. 🧹 Nitpick | 🔵 Trivial TODO comment references issue #471 for qiskit-ibm-runtime constraint. The upper bound If you'd like, I can help monitor or generate a reminder to revisit this constraint when issue #471 is addressed. 🤖 Prompt for AI Agents |
||
| "sb3_contrib>=2.0.0", | ||
| "stable-baselines3>=2.7.0", | ||
| "tqdm>=4.66.0", | ||
| "rich>=12.6.0", | ||
| "scikit-learn>=1.5.1", | ||
|
|
@@ -45,6 +48,8 @@ dependencies = [ | |
| "numpy>=1.24; python_version >= '3.11'", | ||
| "numpy>=1.22", | ||
| "typing-extensions>=4.1", # for `assert_never` | ||
| "qiskit-ibm-transpiler==0.13.1; python_version < '3.13'", # Do not support python 3.13 yet | ||
| "qiskit-ibm-ai-local-transpiler==0.4.2; python_version < '3.13'", | ||
|
Comment on lines
+51
to
+52
There was a problem hiding this comment. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Check latest versions for the pinned transpiler packages
echo "=== Checking qiskit-ibm-transpiler ==="
curl -s https://pypi.org/pypi/qiskit-ibm-transpiler/json | \
jq -r '"Version pinned: 0.13.1\nLatest version: " + .info.version'
echo -e "\n=== Checking qiskit-ibm-ai-local-transpiler ==="
curl -s https://pypi.org/pypi/qiskit-ibm-ai-local-transpiler/json | \
jq -r '"Version pinned: 0.4.2\nLatest version: " + .info.version'
echo -e "\n=== Checking release dates ==="
echo "qiskit-ibm-transpiler releases:"
curl -s https://pypi.org/pypi/qiskit-ibm-transpiler/json | \
jq -r '.releases | keys[] | select(. == "0.13.1" or startswith("0.14") or startswith("0.15") or startswith("1."))' | head -5
echo -e "\nqiskit-ibm-ai-local-transpiler releases:"
curl -s https://pypi.org/pypi/qiskit-ibm-ai-local-transpiler/json | \
jq -r '.releases | keys[] | select(. == "0.4.2" or startswith("0.5") or startswith("1."))' | head -5Repository: munich-quantum-toolkit/predictor Length of output: 208 🌐 Web query:
💡 Result: The latest PyPI release is qiskit-ibm-transpiler 0.14.5 — published on Nov 21, 2025. [1] You can install it with: pip install qiskit-ibm-transpiler. [1] Sources: 🌐 Web query:
💡 Result: Latest PyPI version: 0.4.2 (released Jul 2, 2025). [1] Install: pip install qiskit-ibm-ai-local-transpiler==0.4.2. [1] Sources: 🌐 Web query:
💡 Result: Relevant security advisories / CVEs affecting Qiskit (including QPY/Qiskit SDK / IBM runtime components):
If you want, I can fetch official vendor advisory pages, NVD entries, and exact fixed versions/mitigations for each CVE. Citations:
🌐 Web query:
💡 Result: Short answer: I found no public CVE that specifically names qiskit-ibm-ai-local-transpiler. Related/nearby Qiskit security advisories you should watch:
Sources: If you want, I can: (a) monitor for new CVEs for that package and alert you, or (b) search specific GitHub security advisories/issue trackers for the repo. Which do you prefer? 🌐 Web query:
💡 Result: Yes — qiskit-ibm-transpiler 0.14.5 is published for Python 3 (built/uploaded with CPython 3.13.7), so it supports Python 3.13. [1][2] Sources:
🌐 Web query:
💡 Result: qiskit-ibm-transpiler 0.14.0 (released 2025-08-21) supports Python 3.9 and newer (the package wheels are published as py3 / py3-none-any). [1][2] Sources:
Update
🤖 Prompt for AI Agents |
||
| ] | ||
|
|
||
| classifiers = [ | ||
|
|
@@ -126,6 +131,8 @@ filterwarnings = [ | |
| 'ignore:.*qiskit.providers.models is deprecated since Qiskit 1.2*:DeprecationWarning:', | ||
| 'ignore:.*The class ``qiskit.qobj.*`` is deprecated as of Qiskit 1.3.*:DeprecationWarning:', | ||
| 'ignore:.*The property ``qiskit.circuit.instruction.Instruction.*`` is deprecated as of qiskit 1.3.0.*:DeprecationWarning:', | ||
| 'ignore:.*Timeout is not supported on Windows\\.:RuntimeWarning', | ||
flowerthrower marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| ] | ||
|
|
||
| [tool.coverage] | ||
|
|
@@ -163,7 +170,7 @@ implicit_reexport = true | |
| # recent versions of `gym` are typed, but stable-baselines3 pins a very old version of gym. | ||
| # qiskit is not yet marked as typed, but is typed mostly. | ||
| # the other libraries do not have type stubs. | ||
| module = ["qiskit.*", "joblib.*", "sklearn.*", "matplotlib.*", "gymnasium.*", "mqt.bench.*", "sb3_contrib.*", "bqskit.*", "qiskit_ibm_runtime.*", "networkx.*", "stable_baselines3.*","qiskit_ibm_transpiler.*"] | ||
| ignore_missing_imports = true | ||
|
|
||
| [tool.ruff] | ||
|
|
@@ -249,6 +256,9 @@ aer = "aer" | |
| fom = "fom" | ||
|
|
||
| [tool.repo-review] | ||
| ignore = ["GH200"] | ||
|
|
||
| [tool.uv] | ||
| override-dependencies = [ | ||
| "networkx==2.8.5", # Required by `qiskit-ibm-transpiler` | ||
|
Comment on lines
+259
to
+263
There was a problem hiding this comment. 🧹 Nitpick | 🔵 Trivial Scope of The uv Please check uv’s documentation for 🤖 Prompt for AI Agents |
||
| ] | ||
|
Comment on lines
+261
to
264
There was a problem hiding this comment. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Check qiskit-ibm-transpiler's networkx dependency requirements
echo "=== Checking qiskit-ibm-transpiler dependencies ==="
# Get the package info - try multiple versions to see requirements
curl -s https://pypi.org/pypi/qiskit-ibm-transpiler/json | jq -r '.releases | keys[]' | grep -E '^0\.(13|12|14)' | sort -V | tail -3
echo -e "\n=== Fetching latest qiskit-ibm-transpiler info ==="
curl -s https://pypi.org/pypi/qiskit-ibm-transpiler/json | jq -r '.info | "\(.version): requires_dist=\(.requires_dist)"' | head -20
echo -e "\n=== Checking networkx requirements from qiskit-ibm-transpiler ==="
curl -s https://pypi.org/pypi/qiskit-ibm-transpiler/json | jq -r '.info.requires_dist[]? | select(. | contains("networkx"))'
echo -e "\n=== Checking networkx releases around 2.8.5 ==="
curl -s https://pypi.org/pypi/networkx/json | jq -r '.releases | keys[] | select(startswith("2.8") or startswith("2.9") or startswith("3."))' | sort -V
echo -e "\n=== Checking if 2.8.5 exists ==="
curl -s https://pypi.org/pypi/networkx/2.8.5/json | jq -r '.info.version // "NOT_FOUND"'Repository: munich-quantum-toolkit/predictor Length of output: 208 🏁 Script executed: #!/bin/bash
# Check qiskit-ibm-transpiler's networkx dependency requirements
echo "=== Checking qiskit-ibm-transpiler latest version ==="
LATEST_QIT=$(curl -s https://pypi.org/pypi/qiskit-ibm-transpiler/json | jq -r '.info.version')
echo "Latest version: $LATEST_QIT"
echo -e "\n=== Checking networkx requirements from qiskit-ibm-transpiler ==="
curl -s https://pypi.org/pypi/qiskit-ibm-transpiler/json | jq -r '.info.requires_dist[]? | select(. | contains("networkx"))'
echo -e "\n=== Checking networkx release history around 2.8.5 ==="
curl -s https://pypi.org/pypi/networkx/json | jq -r '.releases | keys[] | select(startswith("2.8") or startswith("2.9") or startswith("3.0") or startswith("3.1"))' | sort -V | tail -10
echo -e "\n=== Verifying networkx 2.8.5 exists ==="
curl -s https://pypi.org/pypi/networkx/2.8.5/json 2>/dev/null | jq -r '.info.version // .info // "NOT_FOUND"' | head -1
echo -e "\n=== Checking networkx compatibility across versions ==="
curl -s https://pypi.org/pypi/networkx/json | jq -r '.releases | keys[] | select(startswith("2.8") or startswith("2.9"))' | sort -VRepository: munich-quantum-toolkit/predictor Length of output: 208 🌐 Web query:
💡 Result: On PyPI qiskit-ibm-transpiler declares networkx as a dependency but without a pinned version specifier (i.e. it requires "networkx" generically). [1][2] Sources:
🌐 Web query:
💡 Result: Short answer: Qiskit no longer requires networkx for most core functionality, but some parts still need it — so networkx 2.8.5 is fine to use if you install it when needed. Details (sources):
Recommendation: If your code calls qiskit.dagcircuit.DAGCircuit.to_networkx / from_networkx or uses qiskit-ignis/topological code, pip-install networkx (pip install "networkx==2.8.5" or a compatible 2.8.x). Otherwise you can rely on the default qiskit installation which uses retworkx for graph operations. [1][2] Sources: The networkx==2.8.5 pin is unnecessarily restrictive and not actually required by qiskit-ibm-transpiler. qiskit-ibm-transpiler declares networkx as a dependency without specifying a version constraint—it accepts any networkx version. Pinning to exactly 2.8.5 is overly strict and likely a legacy requirement that will cause unnecessary dependency conflicts. Consider using a more flexible constraint (e.g., 🤖 Prompt for AI Agents
Comment on lines
+261
to
264
There was a problem hiding this comment. 🧩 Analysis chain🌐 Web query:
💡 Result: Short answer: override-dependencies entries use standard PEP 508 dependency specifiers (name, optional extras, version specifier, optional environment marker). To constrain by Python version put the marker after a semicolon and quote the version. Examples:
Notes:
Sources: 🏁 Script executed: # Check the pyproject.toml around lines 51-52 to see transpiler dependency format
cat -n pyproject.toml | sed -n '40,65p'Repository: munich-quantum-toolkit/predictor Length of output: 208 🌐 Web query:
💡 Result: Short answer: NetworkX 2.8.5 is not compatible with Python 3.13 (it supports Python 3.8–3.10), so if qiskit-ibm-transpiler requires or installs networkx==2.8.5 you cannot use that combo on Python 3.13. [1][2][3] Details & sources:
Recommendation: either use Python 3.10 (to keep networkx 2.8.5), or upgrade NetworkX to a 3.x release that supports Python 3.13 and ensure qiskit-ibm-transpiler is compatible with that NetworkX version (check the transpiler’s dependency metadata or test in a venv). [2][3] Sources: 🌐 Web query:
💡 Result: Short answer: Yes — qiskit-ibm-transpiler depends on networkx (but does not pin a restrictive networkx version), and networkx releases (3.4+) support Python 3.13, while recent Qiskit releases add official Python 3.13 support. So you can run qiskit-ibm-transpiler on Python 3.13 after installing a networkx release that supports 3.13 (e.g. networkx 3.4+). [1][2][3] Sources
References
🏁 Script executed: # Try to fetch raw file from GitHub
curl -s "https://raw.githubusercontent.com/munich-quantum-toolkit/predictor/HEAD/pyproject.toml" | sed -n '40,280p' | cat -n | grep -A 20 -B 5 "networkx\|qiskit-ibm-transpiler" | head -100Repository: munich-quantum-toolkit/predictor Length of output: 208 Based on the web search results, I can now provide a conclusive verification: The review comment's concern is valid and the suggested fix is necessary. Key findings:
The correct implementation should be: [tool.uv]
override-dependencies = [
"networkx==2.8.5; python_version < \"3.13\"", # Required by `qiskit-ibm-transpiler`
]Add a Python version constraint to the networkx override dependency. NetworkX 2.8.5 supports only Python 3.8–3.10 and is incompatible with Python 3.13. Without the constraint, users on Python 3.13 will encounter resolution failures. Update the override to: 🤖 Prompt for AI Agents |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -203,12 +203,15 @@ def estimated_success_probability(qc: QuantumCircuit, device: Target, precision: | |
| if first_qubit_idx not in active_qubits: | ||
| continue | ||
|
|
||
| dt = device.dt # discrete time unit used in duration | ||
| res *= np.exp( | ||
| -instruction.duration | ||
| * dt | ||
| / min(device.qubit_properties[first_qubit_idx].t1, device.qubit_properties[first_qubit_idx].t2) | ||
| ) | ||
| continue | ||
| res *= 1 - device[gate_type][first_qubit_idx,].error | ||
|
|
||
| else: | ||
| second_qubit_idx = calc_qubit_index(qargs, qc.qregs, 1) | ||
| res *= 1 - device[gate_type][first_qubit_idx, second_qubit_idx].error | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should definitely add these (and some other major) changes to the changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please do so in
CHANGELOG.md.