Add new function getSystemInfo #4535
Open
+129
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original author @Pirulax (#2267)
I’m not sure why the original PR was closed - probably due to being abandoned and not updated after review. As for the “privacy” aspect (though I don’t know if anyone still believes it actually exists), if it’s really necessary, we could add a checkbox in the settings. If someone wants to “maintain privacy,” they could simply uncheck it, and then
getSystemInfofor that client would just return false. I’m waiting for feedback on whether this is actually needed.This function will allow server owners to properly adjust their server for older computers, whose users experience FPS drops during rain, weapon/fx effects rendering. Without it, server creators cannot ensure smooth gameplay for everyone, even on a low-end PC.