Remove a couple of superfluous checks

`new X()` will raise an exception if memory allocation fails

This means it will never return nullptr

Therefore these checks are unnecessary

Author: qaisjp

Client/mods/deathmatch/logic/CClientGame.cpp

@@ -3547,27 +3547,21 @@ void CClientGame::Event_OnIngame(void)
 
     // Create a local player for us
     m_pLocalPlayer = new CClientPlayer(m_pManager, m_LocalID, true);
-    if (m_pLocalPlayer)
-    {
-        // Set our parent the root entity
-        m_pLocalPlayer->SetParent(m_pRootEntity);
 
-        // Give the local player our nickname
-        m_pLocalPlayer->SetNick(m_strLocalNick);
+    // Set our parent the root entity
+    m_pLocalPlayer->SetParent(m_pRootEntity);
 
-        // Freeze the player at some location we won't see
-        m_pLocalPlayer->SetHealth(100);
-        m_pLocalPlayer->SetPosition(CVector(0, 0, 0));
-        m_pLocalPlayer->SetFrozen(true);
-        m_pLocalPlayer->ResetInterpolation();
+    // Give the local player our nickname
+    m_pLocalPlayer->SetNick(m_strLocalNick);
 
-        // Reset him
-        m_pLocalPlayer->ResetStats();
-    }
-    else
-    {
-        RaiseFatalError(2);
-    }
+    // Freeze the player at some location we won't see
+    m_pLocalPlayer->SetHealth(100);
+    m_pLocalPlayer->SetPosition(CVector(0, 0, 0));
+    m_pLocalPlayer->SetFrozen(true);
+    m_pLocalPlayer->ResetInterpolation();
+
+    // Reset him
+    m_pLocalPlayer->ResetStats();
 
     // Make sure we never get tired
     g_pGame->GetPlayerInfo()->SetDoesNotGetTired(true);

Client/mods/deathmatch/logic/CStaticFunctionDefinitions.cpp

@@ -2661,20 +2661,18 @@ CClientVehicle* CStaticFunctionDefinitions::CreateVehicle(CResource& Resource, u
             CClientVehicleManager::GetRandomVariation(usModel, ucVariation, ucVariation2);
 
         CClientVehicle* pVehicle = new CDeathmatchVehicle(m_pManager, NULL, INVALID_ELEMENT_ID, usModel, ucVariation, ucVariation2);
-        if (pVehicle)
-        {
-            pVehicle->SetParent(Resource.GetResourceDynamicEntity());
-            pVehicle->SetPosition(vecPosition);
 
-            pVehicle->SetRotationDegrees(vecRotation);
-            if (szRegPlate)
-                pVehicle->SetRegPlate(szRegPlate);
+        pVehicle->SetParent(Resource.GetResourceDynamicEntity());
+        pVehicle->SetPosition(vecPosition);
 
-            return pVehicle;
-        }
+        pVehicle->SetRotationDegrees(vecRotation);
+        if (szRegPlate)
+            pVehicle->SetRegPlate(szRegPlate);
+
+        return pVehicle;
     }
 
-    return NULL;
+    return nullptr;
 }
 
 bool CStaticFunctionDefinitions::FixVehicle(CClientEntity& Entity)
@@ -3738,17 +3736,15 @@ CClientObject* CStaticFunctionDefinitions::CreateObject(CResource& Resource, uns
 #else
         CClientObject* pObject = new CDeathmatchObject(m_pManager, m_pMovingObjectsManager, INVALID_ELEMENT_ID, usModelID, bLowLod);
 #endif
-        if (pObject)
-        {
-            pObject->SetParent(Resource.GetResourceDynamicEntity());
-            pObject->SetPosition(vecPosition);
-            pObject->SetRotationDegrees(vecRotation);
 
-            return pObject;
-        }
+        pObject->SetParent(Resource.GetResourceDynamicEntity());
+        pObject->SetPosition(vecPosition);
+        pObject->SetRotationDegrees(vecRotation);
+
+        return pObject;
     }
 
-    return NULL;
+    return nullptr;
 }
 
 bool CStaticFunctionDefinitions::GetObjectScale(CClientObject& Object, CVector& vecScale)
@@ -3969,17 +3965,13 @@ CClientRadarArea* CStaticFunctionDefinitions::CreateRadarArea(CResource& Resourc
 {
     // Create it
     CClientRadarArea* pRadarArea = new CClientRadarArea(m_pManager, INVALID_ELEMENT_ID);
-    if (pRadarArea)
-    {
-        pRadarArea->SetParent(Resource.GetResourceDynamicEntity());
-        pRadarArea->SetPosition(vecPosition2D);
-        pRadarArea->SetSize(vecSize);
-        pRadarArea->SetColor(color);
 
-        return pRadarArea;
-    }
+    pRadarArea->SetParent(Resource.GetResourceDynamicEntity());
+    pRadarArea->SetPosition(vecPosition2D);
+    pRadarArea->SetSize(vecSize);
+    pRadarArea->SetColor(color);
 
-    return NULL;
+    return pRadarArea;
 }
 
 bool CStaticFunctionDefinitions::GetRadarAreaColor(CClientRadarArea* RadarArea, SColor& outColor)
@@ -4321,14 +4313,13 @@ CClientRadarMarker* CStaticFunctionDefinitions::CreateBlip(CResource& Resource,
     if (CClientRadarMarkerManager::IsValidIcon(ucIcon) && ucSize <= 25)
     {
         CClientRadarMarker* pBlip = new CClientRadarMarker(m_pManager, INVALID_ELEMENT_ID, sOrdering, usVisibleDistance);
-        if (pBlip)
-        {
-            pBlip->SetParent(Resource.GetResourceDynamicEntity());
-            pBlip->SetPosition(vecPosition);
-            pBlip->SetSprite(ucIcon);
-            pBlip->SetScale(ucSize);
-            pBlip->SetColor(color);
-        }
+
+        pBlip->SetParent(Resource.GetResourceDynamicEntity());
+        pBlip->SetPosition(vecPosition);
+        pBlip->SetSprite(ucIcon);
+        pBlip->SetScale(ucSize);
+        pBlip->SetColor(color);
+
         return pBlip;
     }
 
@@ -4343,14 +4334,13 @@ CClientRadarMarker* CStaticFunctionDefinitions::CreateBlipAttachedTo(CResource&
     if (CClientRadarMarkerManager::IsValidIcon(ucIcon) && ucSize <= 25)
     {
         CClientRadarMarker* pBlip = new CClientRadarMarker(m_pManager, INVALID_ELEMENT_ID, sOrdering, usVisibleDistance);
-        if (pBlip)
-        {
-            pBlip->SetParent(Resource.GetResourceDynamicEntity());
-            pBlip->AttachTo(&Entity);
-            pBlip->SetSprite(ucIcon);
-            pBlip->SetScale(ucSize);
-            pBlip->SetColor(color);
-        }
+
+        pBlip->SetParent(Resource.GetResourceDynamicEntity());
+        pBlip->AttachTo(&Entity);
+        pBlip->SetSprite(ucIcon);
+        pBlip->SetScale(ucSize);
+        pBlip->SetColor(color);
+
         return pBlip;
     }
 
@@ -9395,19 +9385,15 @@ CClientPointLights* CStaticFunctionDefinitions::CreateLight(CResource& Resource,
 {
     // Create it
     CClientPointLights* pLight = new CClientPointLights(m_pManager, INVALID_ELEMENT_ID);
-    if (pLight)
-    {
-        pLight->SetParent(Resource.GetResourceDynamicEntity());
-        pLight->SetMode(iMode);
-        pLight->SetPosition(vecPosition);
-        pLight->SetRadius(fRadius);
-        pLight->SetColor(color);
-        pLight->SetDirection(vecDirection);
 
-        return pLight;
-    }
+    pLight->SetParent(Resource.GetResourceDynamicEntity());
+    pLight->SetMode(iMode);
+    pLight->SetPosition(vecPosition);
+    pLight->SetRadius(fRadius);
+    pLight->SetColor(color);
+    pLight->SetDirection(vecDirection);
 
-    return NULL;
+    return pLight;
 }
 
 bool CStaticFunctionDefinitions::GetLightType(CClientPointLights* pLight, int& iMode)