Skip to content

prefer_integer: exclude numbers with leading zero and negative zero #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

prefer_integer: exclude numbers with leading zero and negative zero #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Data/MessagePack/PP.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ sub _pack {
if ( $flags & B::SVp_POK ) { # raw / check needs before double

if ( $self->{prefer_integer} ) {
if ( $value =~ /^-?[0-9]+$/ ) { # ok?
if ( $value =~ /^(0|-?[1-9][0-9]*)$/ ) { # ok?
# checks whether $value is in (u)int32
my $ivalue = 0 + $value;
if (!(
Expand Down
2 changes: 2 additions & 0 deletions t/05_preferred_int.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,10 @@ my @dat = (
'', 'c4 00',
'0', '00',
'1', '01',
'01', 'c4 02 30 31',
'10', '0a',
'-1', 'ff',
'-0', 'c4 02 2d 30',
'-10', 'f6',
'-', 'c4 01 2d',
''.0xEFFF => 'cd ef ff',
Expand Down
2 changes: 2 additions & 0 deletions xs-src/pack.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,8 @@ STATIC_INLINE int try_int(enc_t* enc, const char *p, size_t len) {
if (len > 10) { return 0; }
}

if (*p == '0' && len != 1) { return 0; }

#if '9'=='8'+1 && '8'=='7'+1 && '7'=='6'+1 && '6'=='5'+1 && '5'=='4'+1 \
&& '4'=='3'+1 && '3'=='2'+1 && '2'=='1'+1 && '1'=='0'+1
do {
Expand Down