Skip to content

Fix buffer attribute matrix validation #32462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
techcodie wants to merge 2 commits into from
Closed

Fix buffer attribute matrix validation #32462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
013523c
Update README.md
techcodie Nov 16, 2025
b9cd6f8
Add validation for BufferAttribute matrix methods
techcodie Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
[![jsDelivr Downloads][jsdelivr-downloads]][jsdelivr-url]
[![Discord][discord]][discord-url]

#### JavaScript 3D library
#### JavaScript 3D library

The aim of the project is to create an easy-to-use, lightweight, cross-browser, general-purpose 3D library. The current builds only include WebGL and WebGPU renderers but SVG and CSS3D renderers are also available as addons.

Expand Down
21 changes: 21 additions & 0 deletions src/core/BufferAttribute.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,13 @@ class BufferAttribute {
*/
applyMatrix4( m ) {

if ( this.itemSize !== 3 ) {

console.warn( 'THREE.BufferAttribute.applyMatrix4(): itemSize is not 3, which is required.' );
return this;

}

for ( let i = 0, l = this.count; i < l; i ++ ) {

_vector.fromBufferAttribute( this, i );
Expand All @@ -319,6 +326,13 @@ class BufferAttribute {
*/
applyNormalMatrix( m ) {

if ( this.itemSize !== 3 ) {

console.warn( 'THREE.BufferAttribute.applyNormalMatrix(): itemSize is not 3, which is required.' );
return this;

}

for ( let i = 0, l = this.count; i < l; i ++ ) {

_vector.fromBufferAttribute( this, i );
Expand All @@ -342,6 +356,13 @@ class BufferAttribute {
*/
transformDirection( m ) {

if ( this.itemSize !== 3 ) {

console.warn( 'THREE.BufferAttribute.transformDirection(): itemSize is not 3, which is required.' );
return this;

}

for ( let i = 0, l = this.count; i < l; i ++ ) {

_vector.fromBufferAttribute( this, i );
Expand Down