Revert 1 fix/alert to console #32459
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 3, 2025 00:20
Fix: Replace alert with console.log in EventDispatcher example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the documentation in src/core/EventDispatcher.js by replacing an outdated alert() call with console.log() in the usage example.
Previously, the example used alert() to demonstrate event handling, which is discouraged as it blocks the main thread and interrupts the user experience.
Additionally, the example has been expanded to include a stop() method and a corresponding event listener, providing a more comprehensive demonstration of how to define and handle custom events.
Linked Issues
N/A
Additional context
Verified that the updated example code is valid JavaScript and correctly demonstrates the EventDispatcher functionality.