Fix: add setMaterialMap utility to safely switch Texture to VideoTexture #31934 #32221
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces a new utility
setMaterialMap.jsthat addresses issue #31934.setMaterialMapfunction is designed to be called whenever assigning a texture to a material'smapproperty, particularly for special cases likeVideoTexture, wherematerial.needsUpdatemust be set to ensure proper rendering updates.Changes:
utils/setMaterialMap.jsas a reusable function to safely assign textures to materials.material.needsUpdate = trueautomatically when switching from a regularTextureto aVideoTexture(or any dynamic texture), preventing potential rendering issues or crashes.Usage Example:
Instead of manually doing: