Skip to content

Implement all commands of Ctap2 #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Nov 15, 2021
Merged

Implement all commands of Ctap2 #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
bfe6fb4
WIP: Add part MakeCredentials
May 11, 2021
0e746fb
Add test for (and do some fixes) for MakeCredential CTAP1 mapping
May 12, 2021
c35619e
Adjust tests with RelyingParty and name-field
May 12, 2021
26f231a
Fix serialization of MakeCredentialOptions (individually serialize me…
May 12, 2021
f7dd900
Temporarily parse credential_public_key just as a byte-vector, until …
May 12, 2021
bf12cdb
Add Option Unparsed to AttestationStatement, to currently skip parsin…
May 17, 2021
4345004
Add commands GetAssertion and GetAssertionNext. Still missing tests.
May 20, 2021
d62a52a
WIP: Add clientpin command with all the crypto functionality commente…
May 21, 2021
15eb9ed
Remove duplicate Pin-definition
May 25, 2021
2980fb8
MakeCredentials and GetAssertion now do not store Pin but PinAuth, wh…
May 25, 2021
5f3930c
MakeCredentials: Remove pointless alias for HIDError
Jun 15, 2021
1b085b2
GetInfo: Fix wrong parsing of response. Forgot to strip away the stat…
Jun 18, 2021
e206255
Make naming of CommandError variants consistent and remove redundant …
Nov 5, 2021
a147e50
Replace custom error with invalid_length (even though the usage is a …
Nov 5, 2021
386d616
Use From<CommandError>-trait of HIDError to avoid verbose map_err-cal…
Nov 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ maintenance = { status = "actively-developed" }

[features]
binding-recompile = ["bindgen"]
webdriver = ["base64", "bytes", "warp", "tokio", "serde_json"]
webdriver = ["bytes", "warp", "tokio"]

[target.'cfg(target_os = "linux")'.dependencies]
libudev = "^0.2"
Expand Down Expand Up @@ -48,14 +48,17 @@ bitflags = "1.0"
tokio = { version = "0.2", optional = true, features = ["macros"] }
warp = { version = "0.2.4", optional = true }
serde = { version = "1.0", features = ["derive"] }
serde_bytes = "0.11"
serde_cbor = "0.11"
serde_json = { version = "1.0", optional = true }
serde_json = "1.0"
bytes = { version = "0.5", optional = true, features = ["serde"] }
base64 = { version = "^0.10", optional = true }
base64 = "^0.10"
nom = "^5.1"
sha2 = "^0.8.0"
Copy link
Contributor

@rmartinho rmartinho Oct 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we use sha2 0.9, it uses digest 0.9, which in turn uses generic-array 0.13, which supports has impl Into<[T; N]> for GenericArrays.

Copy link
Contributor Author

@msirringhaus msirringhaus Nov 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried to use the versions that are already vendored in Firefox, to avoid update procedures there that might cause problems. Currently, Firefox has sha2 in version 0.8.2.
If you think it's not a problem to bump that dependency in Firefox as well, I can go with 0.9.


[dev-dependencies]
sha2 = "^0.8.2"
base64 = "^0.10"
env_logger = "^0.6"
getopts = "^0.2"
assert_matches = "1.2"
byteorder = "^1.3.2"
Loading