Skip to content

Added contain_forbidden_parts and vehicle_not_fully_in_frame compliances #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added contain_forbidden_parts and vehicle_not_fully_in_frame compliances #944

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions packages/common/src/i18n/translations/image.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,4 +430,46 @@ export const complianceIssueLabels: Record<ComplianceIssue, ImageLabels> = {
nl: 'De foto is in portretstand, neem deze alstublieft in landschapmodus',
},
},
[ComplianceIssue.CONTAIN_FORBIDDEN_PARTS]: {
title: {
en: 'Contain forbidden parts',
fr: 'Contient des parties interdites',
de: 'Enthält verbotene Teile',
nl: 'Bevat verboden onderdelen',
},
description: {
en: 'Make sure to properly align the vehicle with the guides.',
fr: 'Assurez-vous de bien aligner le véhicule avec les guides.',
de: 'Achten Sie darauf, dass das Fahrzeug richtig an den Führungen ausgerichtet ist.',
nl: 'Zorg ervoor dat het voertuig goed is uitgelijnd met de gidsen.',
},
},
[ComplianceIssue.VEHICLE_NOT_FULLY_IN_FRAME]: {
title: {
en: 'Vehicle not fully in frame',
fr: 'Véhicule pas entièrement dans le cadre',
de: 'Fahrzeug nicht vollständig im Bild',
nl: 'Voertuig niet volledig in beeld',
},
description: {
en: 'Make sure that the entire vehicle is visible in the photo.',
fr: "Assurez-vous que l'intégralité du véhicule soit visible sur la photo.",
de: 'Stellen Sie sicher, dass das gesamte Fahrzeug auf dem Foto sichtbar ist.',
nl: 'Zorg ervoor dat het hele voertuig op de foto zichtbaar is.',
},
},
[ComplianceIssue.FINGER_ON_LENS]: {
title: {
en: 'Finger on lens',
fr: "Doigt sur l'objectif",
de: 'Finger auf dem Objektiv',
nl: 'Vinger op de lens',
},
description: {
en: 'Make sure that there is no finger on the camera lens.',
fr: "Assurez-vous qu'il n'y ait pas de doigt sur l'objectif de l'appareil photo.",
de: 'Stellen Sie sicher, dass kein Finger auf dem Kameraobjektiv liegt.',
nl: 'Zorg ervoor dat er geen vinger op de cameralens zit.',
},
},
};
3 changes: 3 additions & 0 deletions packages/network/test/api/image/mappers.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ const EXPECTED_DEFAULT_COMPLIANCE_ISSUES = [
];

const EXPECTED_COMPLIANCE_ISSUES_ORDER = [
ComplianceIssue.CONTAIN_FORBIDDEN_PARTS,
ComplianceIssue.VEHICLE_NOT_FULLY_IN_FRAME,
ComplianceIssue.FINGER_ON_LENS,
ComplianceIssue.PORTRAIT_IMAGE,
ComplianceIssue.NO_VEHICLE,
ComplianceIssue.BLURRINESS,
Expand Down
3 changes: 3 additions & 0 deletions packages/types/src/state/image.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,9 @@ export enum ComplianceIssue {
INTERIOR_NOT_SUPPORTED = 'interior_not_supported',
MISSING = 'missing',
LOW_QUALITY = 'low_quality',
CONTAIN_FORBIDDEN_PARTS = 'contain_forbidden_parts',
VEHICLE_NOT_FULLY_IN_FRAME = 'vehicle_not_fully_in_frame',
FINGER_ON_LENS = 'finger_on_lens',

// Custom issue(s)
PORTRAIT_IMAGE = 'portrait_image',
Expand Down