Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/acceptance-tests-runner.yml
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,7 @@ jobs:
- 'internal/provider/*.go'
autogen_fast:
- 'internal/common/autogen/*.go'
- 'internal/serviceapi/alertconfigurationapi/*.go'
- 'internal/serviceapi/auditingapi/*.go'
- 'internal/serviceapi/customdbroleapi/*.go'
- 'internal/serviceapi/databaseuserapi/*.go'
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ tools: ## Install the dev tools (dependencies)
go install github.com/icholy/gomajor@latest
go install github.com/terraform-linters/tflint@v0.52.0
go install github.com/rhysd/actionlint/cmd/actionlint@latest
go install golang.org/x/tools/go/analysis/passes/fieldalignment/cmd/fieldalignment@latest
go install golang.org/x/tools/go/analysis/passes/fieldalignment/cmd/fieldalignment@v0.38.0 # Pinning version since v0.39.0 fails to fix files with large structs. See versions at https://pkg.go.dev/golang.org/x/tools/go/analysis/passes/fieldalignment?tab=versions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't see a concern but curious was this a bug on their latest version (0.39.0)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It only started happening today, checked versions and 0.39 was released yesterday.
Can change back to latest when fixed, haven't looked if there is an associated bug.

go install github.com/hashicorp/terraform-plugin-docs/cmd/tfplugindocs@latest
go install github.com/hashicorp/terraform-plugin-codegen-openapi/cmd/tfplugingen-openapi@latest
go install github.com/hashicorp/terraform-plugin-codegen-framework/cmd/tfplugingen-framework@latest
Expand Down
6 changes: 3 additions & 3 deletions internal/service/alertconfiguration/resource_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ func TestAccConfigRSAlertConfiguration_basic(t *testing.T) {
ImportStateIdFunc: importStateProjectIDFunc(resourceName),
ImportState: true,
ImportStateVerify: true,
ImportStateVerifyIgnore: []string{"project_id", "updated"},
ImportStateVerifyIgnore: []string{"updated"},
},
},
})
Expand Down Expand Up @@ -147,7 +147,7 @@ func TestAccConfigRSAlertConfiguration_withNotifications(t *testing.T) {
ImportStateIdFunc: importStateProjectIDFunc(resourceName),
ImportState: true,
ImportStateVerify: true,
ImportStateVerifyIgnore: []string{"project_id", "updated"},
ImportStateVerifyIgnore: []string{"updated"},
},
},
})
Expand Down Expand Up @@ -263,7 +263,7 @@ func TestAccConfigRSAlertConfiguration_withThreshold(t *testing.T) {
ImportStateIdFunc: importStateProjectIDFunc(resourceName),
ImportState: true,
ImportStateVerify: true,
ImportStateVerifyIgnore: []string{"project_id", "updated", "matcher.0.field_name"},
ImportStateVerifyIgnore: []string{"updated", "matcher.0.field_name"},
},
},
})
Expand Down
15 changes: 15 additions & 0 deletions internal/serviceapi/alertconfigurationapi/main_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
package alertconfigurationapi_test

import (
"os"
"testing"

"github.com/mongodb/terraform-provider-mongodbatlas/internal/testutil/acc"
)

func TestMain(m *testing.M) {
cleanup := acc.SetupSharedResources()
exitCode := m.Run()
cleanup()
os.Exit(exitCode)
}
149 changes: 149 additions & 0 deletions internal/serviceapi/alertconfigurationapi/resource.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading