chore: Adds provider_meta support to all data sources #3868
+185
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds provider_meta support to all data sources (TPF and SDKv2) for module usage tracking via User-Agent headers. Follows the same pattern as resources (PR #3618). - Created datasource_base.go for data source analytics in TPF - Added SetClient() method pattern matching resources - Shared asUserAgentExtraFromProviderMeta() between resources and data sources
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds provider_meta support to all data sources (both TPF and SDKv2) to enable module usage tracking via User-Agent headers, following the same pattern previously implemented for resources.
Key changes:
- Created new
datasource_base.gofile for TPF data source analytics tracking - Extended
NewAnalyticsResourceSDKv2to support both resources and data sources viaisDataSourceparameter - Refactored User-Agent extra logic into shared
asUserAgentExtraFromProviderMetafunction
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/provider/provider_sdk2.go | Wraps SDKv2 data sources with analytics support and updates resource wrapping to pass isDataSource=false |
| internal/provider/provider.go | Wraps TPF data sources with analytics support using new AnalyticsDataSourceFunc |
| internal/config/user_agent.go | Adds userAgentNameValueDataSource helper to format data source names with "data." prefix |
| internal/config/resource_base_sdkv2.go | Extracts analytics logic into shared updateContextWithProviderMetaSDKv2 function supporting both resources and data sources |
| internal/config/resource_base.go | Refactors to use shared asUserAgentExtraFromProviderMeta function and removes DSCommon (moved to datasource_base.go) |
| internal/config/datasource_base.go | New file implementing DSCommon with analytics wrapper pattern for TPF data sources |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lantoli
reviewed
Nov 11, 2025
| // When embedded, the data source's own Schema method is used | ||
| } | ||
|
|
||
| func (d *DSCommon) Configure(ctx context.Context, req datasource.ConfigureRequest, resp *datasource.ConfigureResponse) { |
Member
There was a problem hiding this comment.
should we have some tests or will be (indirectly) tested with all acc tests?
Collaborator
Author
There was a problem hiding this comment.
Correct, tested indirectly.
lantoli
approved these changes
Nov 11, 2025
manupedrozo
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds provider_meta support to all data sources (TPF and SDKv2) for module usage tracking via User-Agent headers. Follows the same pattern as resources (PR #3618).
Link to any related issue(s): CLOUDP-340210
Type of change:
Required Checklist:
Further comments