Skip to content

fix(NODE-7290): deserialize error with promoteValues #4783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −2
Open

fix(NODE-7290): deserialize error with promoteValues #4783

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97f674e
fix: deserialize error with promoteValues
paula-stacho Nov 6, 2025
b2a8191
lint
paula-stacho Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/cmap/connection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,6 +499,10 @@ export class Connection extends TypedEventEmitter<ConnectionEvents> {
}
}

private deserializeError(document: Document, bsonOptions: DeserializeOptions): Document {
return document.toObject({ ...bsonOptions, promoteValues: true });
}

private async *sendCommand(
ns: MongoDBNamespace,
command: Document,
Expand Down Expand Up @@ -551,10 +555,10 @@ export class Connection extends TypedEventEmitter<ConnectionEvents> {
if (document.ok === 0) {
if (options.timeoutContext?.csotEnabled() && document.isMaxTimeExpiredError) {
throw new MongoOperationTimeoutError('Server reported a timeout error', {
cause: new MongoServerError((object ??= document.toObject(bsonOptions)))
cause: new MongoServerError((object ??= this.deserializeError(document, bsonOptions)))
});
}
throw new MongoServerError((object ??= document.toObject(bsonOptions)));
throw new MongoServerError((object ??= this.deserializeError(document, bsonOptions)));
}

if (this.shouldEmitAndLogCommand) {
Expand Down