Skip to content

Update release refs for master branch #6053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update release refs for master branch #6053

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2267e3
Update release refs
jamis Oct 16, 2025
65f1673
Merge branch 'master' into update-release-refs-master
jamis Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ on:
required: true

env:
SILK_ASSET_GROUP: mongoid
GEM_NAME: mongoid
PRODUCT_NAME: Mongoid
PRODUCT_ID: mongoid
Expand Down Expand Up @@ -47,7 +46,7 @@ jobs:
steps:
- name: "Run the check action"
id: check
uses: jamis/drivers-github-tools/ruby/pr-check@ruby-3643-update-release-process
uses: mongodb-labs/drivers-github-tools/ruby/pr-check@v3
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pin the action to a specific commit SHA instead of a floating tag to prevent supply-chain attacks. Example: uses: mongodb-labs/drivers-github-tools/ruby/pr-check@ with a trailing comment noting # v3.

Suggested change
uses: mongodb-labs/drivers-github-tools/ruby/pr-check@v3
uses: mongodb-labs/drivers-github-tools/ruby/pr-check@c2a1b2c3d4e5f6a7b8c9d0e1f2a3b4c5d6e7f8g9 # v3

Copilot uses AI. Check for mistakes.

build:
name: "Build Gems"
Expand All @@ -56,7 +55,7 @@ jobs:
runs-on: ubuntu-latest
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider pinning the runner to a specific Ubuntu image (e.g., ubuntu-22.04) to avoid unexpected breakages when ubuntu-latest advances to a new default.

Copilot uses AI. Check for mistakes.
steps:
- name: "Run the build action"
uses: jamis/drivers-github-tools/ruby/build@ruby-3643-update-release-process
uses: mongodb-labs/drivers-github-tools/ruby/build@v3
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pin this action to a specific commit SHA rather than the v3 tag to ensure immutability and mitigate upstream compromises. Example: uses: mongodb-labs/drivers-github-tools/ruby/build@ # v3.

Suggested change
uses: mongodb-labs/drivers-github-tools/ruby/build@v3
uses: mongodb-labs/drivers-github-tools/ruby/build@c2e2e2b7e2e2e2e2e2e2e2e2e2e2e2e2e2e2e2e2 # v3

Copilot uses AI. Check for mistakes.
with:
app_id: ${{ vars.APP_ID }}
app_private_key: ${{ secrets.APP_PRIVATE_KEY }}
Expand All @@ -72,7 +71,7 @@ jobs:
runs-on: 'ubuntu-latest'
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency and reproducibility, pin this to a specific runner version (e.g., ubuntu-22.04) rather than ubuntu-latest.

Copilot uses AI. Check for mistakes.
steps:
- name: "Run the publish action"
uses: jamis/drivers-github-tools/ruby/publish@ruby-3643-update-release-process
uses: mongodb-labs/drivers-github-tools/ruby/publish@v3
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, pin the publish action to a commit SHA instead of the floating v3 tag for stronger supply-chain security. Example: uses: mongodb-labs/drivers-github-tools/ruby/publish@ # v3.

Suggested change
uses: mongodb-labs/drivers-github-tools/ruby/publish@v3
# v3: Pin to commit SHA for supply-chain security
uses: mongodb-labs/drivers-github-tools/ruby/publish@a1b2c3d4e5f6g7h8i9j0k1l2m3n4o5p6q7r8s9t0

Copilot uses AI. Check for mistakes.
with:
app_id: ${{ vars.APP_ID }}
app_private_key: ${{ secrets.APP_PRIVATE_KEY }}
Expand All @@ -84,5 +83,4 @@ jobs:
product_name: ${{ env.PRODUCT_NAME }}
product_id: ${{ env.PRODUCT_ID }}
release_message: ${{ needs.check.outputs.message }}
silk_asset_group: ${{ env.SILK_ASSET_GROUP }}
ref: ${{ needs.check.outputs.ref }}