chore: Expose feature flags for bson3 #1523
Open
+169
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `bson` crate supports useful helper APIs for `chrono`, `jiff`, and other crates. These feature flags aren't exposed through this crate even though it re-exports `bson`. This commit simply exposes those features for users so that they don't have to depend on `bson` directly. This is useful for a few reasons. The first is that depending on a separate copy of `bson` will likely bring in a version different than that of the `mongodb` crate. The different types can conflict as `mongodb::bson::Bson` is different from `bson::Bson`. The second reason is that two copies of the same crate leads to binary bloat. It's likely that tree shaking can't remove either copy because the re-exported `bson` is used within the `mongodb` crate. Both crates, as well the transitive dependencies that differ, will be included in the crate graph. The third reason is that it's simply more ergonomic to have these features exposed through `mongodb` too rather than including a separate crate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
bsoncrate supports useful helper APIs forchrono,jiff, and other crates. These feature flags aren't exposed through this crate even though it re-exportsbson. This commit simply exposes those features for users so that they don't have to depend onbsondirectly.This is useful for a few reasons. The first is that depending on a separate copy of
bsonwill likely bring in a version different than that of themongodbcrate. The different types can conflict asmongodb::bson::Bsonis different frombson::Bson.The second reason is that two copies of the same crate leads to binary bloat. It's likely that tree shaking can't remove either copy because the re-exported
bsonis used within themongodbcrate. Both crates, as well the transitive dependencies that differ, will be included in the crate graph.The third reason is that it's simply more ergonomic to have these features exposed through
mongodbtoo rather than including a separate crate.