Skip to content

PYTHON-5423 Always use subprocess.run instead of subprocess.check_call or subprocess.call #2412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2025
Merged

PYTHON-5423 Always use subprocess.run instead of subprocess.check_call or subprocess.call #2412

merged 1 commit into from
Jun 30, 2025

Conversation

@sleepyStick
Copy link
Contributor

@sleepyStick sleepyStick commented Jun 30, 2025

Didn't find any instances of subprocess.call and all (three) instances of subprocess.check_call(...) are now subprocess.run(..., check=True)

@sleepyStick sleepyStick marked this pull request as ready for review June 30, 2025 17:19
@sleepyStick sleepyStick requested a review from a team as a code owner June 30, 2025 17:19
@sleepyStick sleepyStick requested a review from blink1073 June 30, 2025 17:19
blink1073
blink1073 approved these changes Jun 30, 2025
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sleepyStick sleepyStick merged commit 578c6c2 into mongodb:master Jun 30, 2025
75 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sleepyStick @blink1073