CSHARP-5778: Update search index helper tests #1806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ajcvickers
commented
Nov 6, 2025
ajcvickers
commented
- Ensure index definitions are valid per https://www.mongodb.com/docs/atlas/atlas-search/index-definitions/
- Use unique index name for each variation
- Ensure index definitions are valid per https://www.mongodb.com/docs/atlas/atlas-search/index-definitions/ - Use unique index name for each variation
ajcvickers
added
the
chore
There was a problem hiding this comment.
Pull Request Overview
This PR improves test maintainability for Atlas Search Index tests by refactoring index name generation and addressing test isolation issues. The changes ensure that tests with different parameters (async vs sync, with/without fields) create uniquely named indexes to avoid conflicts.
- Introduced a helper method
CreateIndexNameto generate unique index names based on test parameters - Updated index definitions to use more realistic field configurations
- Refactored test methods to use the new helper and apply correct index definitions based on test parameters
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| baseName += "-async"; | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
There is an extra blank line between the two conditional blocks. Remove one blank line to maintain consistent spacing throughout the method.
Suggested change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.