INTPYTHON-730 Make search index creation and deletion synchronous #379
Conversation
timgraham
force-pushed
the
search-index-wait
branch
from
5983c82 to
5ff1a4c
Compare
| def assertAddRemoveIndex(self, editor, model, index): | ||
| with self.assertNumQueries(1): | ||
| editor.add_index(index=index, model=model) | ||
| editor.add_index(index=index, model=model) |
There was a problem hiding this comment.
There will be some number of list_search_indexes() queries until the index is ready.
timgraham
force-pushed
the
search-index-wait
branch
from
5ff1a4c to
f9be438
Compare
| return db_type and field.unique and field.column != "_id" | ||
|
|
||
| @staticmethod | ||
| def wait_until_index_created(collection, index_name, timeout=60 * 60, interval=0.5): |
There was a problem hiding this comment.
Why is the timeout 60 times more for creation than deletion? (an hour vs a minute
There was a problem hiding this comment.
I believe index creation time is ~O(n) (based on collection size) while it seems like dropping an index would probably be a constant time operation. Noah said that creating an index on a large collection "could definitely take over 60 seconds." We didn't receive an answer for the Atlas team on how to choose these values, but my thought is that if we have a user run into either limit, we can increase it further and/or consider adding an AddIndexConcurrently operation, with the caveat that future migration operations would have to be aware that the index may not be ready.
timgraham
force-pushed
the
search-index-wait
branch
from
f9be438 to
4a3cb38
Compare
2 participants
No description provided.