INTPYTHON-355 Remove transaction support #352
Merged
+42
−197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgraham
force-pushed
the
transaction-revert
branch
2 times, most recently
from
bfd3d8a to
7d40e47
Compare
timgraham
changed the title
timgraham
force-pushed
the
transaction-revert
branch
from
7d40e47 to
a682561
Compare
aclark4life
reviewed
Jul 31, 2025
|
|
||
| def tearDown(self): | ||
| del connection.features.supports_transactions | ||
| del connection.features._supports_transactions |
Collaborator
There was a problem hiding this comment.
This is staying in for QE right or for both QE and future custom atomic ?
aclark4life
approved these changes
Jul 31, 2025
Collaborator
aclark4life
left a comment
aclark4life
left a comment
There was a problem hiding this comment.
Sad to see it go but LGTM! Thanks
timgraham
force-pushed
the
transaction-revert
branch
2 times, most recently
from
56b6640 to
07f078b
Compare
timgraham
force-pushed
the
transaction-revert
branch
from
07f078b to
d5aa1a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MongoDB's best practices for transactions ("use them only when needed") isn't compatible with how Django uses atomic() internally. Instead, a separate atomic() function for use in user code will be provided.