Skip to content

Admin: Allow sorting tags by label and tag values #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from
Open

Admin: Allow sorting tags by label and tag values #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion assets/components/tagger/js/mgr/extras/tagger.combo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,9 @@ tagger.combo.SortField = function(config) {
fields: ['d','v'],
data: [
[_('tagger.group.sort_field_alias') ,'alias'],
[_('tagger.group.sort_field_rank') ,'rank']
[_('tagger.group.sort_field_rank') ,'rank'],
[_('tagger.group.sort_field_tag') ,'tag'],
[_('tagger.group.sort_field_label') ,'label']
]
}),
displayField: 'd',
Expand Down
2 changes: 2 additions & 0 deletions core/components/tagger/lexicon/de/default.inc.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@
$_lang['tagger.group.sort_field_desc'] = 'Sortierfeld - Feld für die Sortierung von Tags';
$_lang['tagger.group.sort_field_alias'] = 'Alias';
$_lang['tagger.group.sort_field_rank'] = 'Rang';
$_lang['tagger.group.sort_field_tag'] = 'Tag';
$_lang['tagger.group.sort_field_label'] = 'Bezeichnung';
$_lang['tagger.group.show_for_contexts'] = 'Für Kontexte anzeigen';
$_lang['tagger.group.show_for_contexts_desc'] = 'Kommagetrennte Liste der Kontexte <strong>KEY</strong>s, in der diese Gruppe angezeigt werden soll. Standardmäßig wird die Gruppe in allen Kontexten angezeigt.';
$_lang['tagger.tab.label'] = 'Tagger';
Expand Down
2 changes: 2 additions & 0 deletions core/components/tagger/lexicon/en/default.inc.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@
$_lang['tagger.group.sort_field_desc'] = 'Sort field - field used for sorting Tags';
$_lang['tagger.group.sort_field_alias'] = 'Alias';
$_lang['tagger.group.sort_field_rank'] = 'Rank';
$_lang['tagger.group.sort_field_tag'] = 'Tag';
$_lang['tagger.group.sort_field_label'] = 'Label';
$_lang['tagger.group.show_for_contexts'] = 'Show for Contexts';
$_lang['tagger.group.show_for_contexts_desc'] = 'Comma separated list of context <strong>KEY</strong>s for that should be this group displayed. By default the group will appear for all contexts.';

Expand Down
2 changes: 1 addition & 1 deletion core/components/tagger/src/Model/TaggerGroup.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public function save($cacheFlag = null)
$this->set('alias', $this->generateUniqueAlias($this->name));
}

if (!in_array($this->sort_field, ['alias', 'rank'])) {
if (!in_array($this->sort_field, ['alias', 'rank', 'tag', 'label'])) {
$this->set('sort_field', 'alias');
}

Expand Down