Skip to content

Make mojo_binary / mojo_test compile action support path mapping #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Make mojo_binary / mojo_test compile action support path mapping #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions mojo/private/mojo_binary_test.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,9 @@ def _find_main(name, srcs, main):

fail("Multiple Mojo files provided, but no main file specified. Please set 'main = \"foo.mojo\"' to disambiguate.")

def _format_include(arg):
return ["-I", arg.dirname]

def _mojo_binary_test_implementation(ctx, *, shared_library = False):
cc_toolchain = find_cpp_toolchain(ctx)
mojo_toolchain = ctx.toolchains["//:toolchain_type"].mojo_toolchain_info
Expand All @@ -83,17 +86,17 @@ def _mojo_binary_test_implementation(ctx, *, shared_library = False):
args.add("build")
args.add("-strip-file-prefix=.")
args.add("--emit", "object")
args.add("-o", object_file.path)
args.add("-o", object_file)

main = _find_main(ctx.label.name, ctx.files.srcs, ctx.file.main)
args.add(main.path)
root_directory = main.dirname
for file in ctx.files.srcs:
if not file.dirname.startswith(root_directory):
args.add("-I", file.dirname)
args.add_all([file], map_each = _format_include)

import_paths, transitive_mojopkgs = collect_mojoinfo(ctx.attr.deps + mojo_toolchain.implicit_deps)
args.add_all(import_paths, before_each = "-I")
_, transitive_mojopkgs = collect_mojoinfo(ctx.attr.deps + mojo_toolchain.implicit_deps)
args.add_all(transitive_mojopkgs, map_each = _format_include)

# NOTE: Argument order:
# 1. Basic functional arguments
Expand Down Expand Up @@ -126,10 +129,14 @@ def _mojo_binary_test_implementation(ctx, *, shared_library = False):
"MODULAR_MOJO_MAX_COMPILERRT_PATH": "/dev/null", # Make sure this fails if accessed
"MODULAR_MOJO_MAX_LINKER_DRIVER": "/dev/null", # Make sure this fails if accessed
"MODULAR_MOJO_MAX_LLD_PATH": mojo_toolchain.lld.path,
# "MODULAR_MOJO_MAX_LLD_PATH": "/dev/null", # Make sure this fails if accessed
Comment on lines 131 to +132
Copy link
Contributor Author

@keith keith Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't work because this path isn't mapped, this is only accessed in some cases

"TEST_TMPDIR": ".",
},
use_default_shell_env = True,
toolchain = "//:toolchain_type",
execution_requirements = {
"supports-path-mapping": "1",
},
)

feature_configuration = cc_common.configure_features(
Expand Down