Bump mist to 25.6 #178
Open
Bump mist to 25.6 #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the mist package recipe to version 25.6.0 and migrates from the legacy max dependency system to the newer mojo-compiler dependency system.
- Version bump from 25.5.0 to 25.6.0
- Migration from
maxtomojo-compilerdependencies - Addition of
mojo_versioncontext variable for version consistency
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| requirements: | ||
| host: | ||
| - max =25.5 | ||
| - mojo-compiler ${{ mojo_version }} |
There was a problem hiding this comment.
[nitpick] The host requirements section uses the template variable ${{ mojo_version }} while other recipes in the codebase (e.g., emberjson/recipe.yaml) use the hardcoded version =0.25.6 in the host section and the template variable in the build section. For consistency, consider using - mojo-compiler =0.25.6 in the host section, matching the pattern used in emberjson.
Suggested change
| - mojo-compiler ${{ mojo_version }} | |
| - mojo-compiler =0.25.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
recipe.yamlfile specifies which version(s) of MAX is compatible with my project (see here for an example). If not, my package is compatible with both 24.5 and 24.6.0(for new packages, or if the version changed).