Skip to content

Add new optional flags for the cprover contracts library. #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
remi-delmas-3000 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add new optional flags for the cprover contracts library. #224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion src/cbmc_starter_kit/template-for-repository/proofs/Makefile.common
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,9 +407,29 @@ ifdef STRING_ABSTRACTION
endif
endif

# User simpler invalid pointer model for contracts with DFCC.
#
# Removes offset nondeterminism for invalid pointers created in failure paths
# of the __CPROVER_is_fresh predicate. Improves performance for some proofs.
# Unsound because of reduced nondeterminism.
Copy link
Contributor

@feliperodri feliperodri Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way that we make this more clear to users? Maybe add unsound to the name of the flag? Does CBMC emit warnings when this flag is used? Is there a PR or GitHub issue link that we could add here?

DFCC_SIMPLE_INVALID_POINTER_MODEL ?=
ifdef DFCC_SIMPLE_INVALID_POINTER_MODEL
ifneq ($(strip $(DFCC_SIMPLE_INVALID_POINTER_MODEL)),)
CBMC_DFCC_SIMPLE_INVALID_POINTER_MODEL := --dfcc-simple-invalid-pointer-model
endif
endif

# Activate debug assertions in the DFCC contracts support library.
DFCC_DEBUG_LIB ?=
ifdef DFCC_DEBUG_LIB
ifneq ($(strip $(DFCC_DEBUG_LIB)),)
CBMC_DFCC_DEBUG_LIB := --dfcc-debug-lib
endif
endif

# Optional configuration library flags
OPT_CONFIG_LIBRARY ?=
CBMC_OPT_CONFIG_LIBRARY := $(CBMC_FLAG_MALLOC_MAY_FAIL) $(CBMC_STRING_ABSTRACTION)
CBMC_OPT_CONFIG_LIBRARY := $(CBMC_FLAG_MALLOC_MAY_FAIL) $(CBMC_STRING_ABSTRACTION) $(DFCC_SIMPLE_INVALID_POINTER_MODEL) $(DFCC_DEBUG_LIB)

# Proof writers could add function contracts in their source code.
# These contracts are ignored by default, but may be enabled in two distinct
Expand Down
Loading