feat: check access token for group membership #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hahahannes
force-pushed
the
group_access_token
branch
from
073be2a to
1634706
Compare
Contributor
Author
|
What do you think about this @kharkevich ? Similar to the other user, we have the case where the groups value is placed in the access token itself and not in the user id token. |
hahahannes
changed the title
Contributor
Author
|
I realized that I should use the |
hahahannes
force-pushed
the
group_access_token
branch
2 times, most recently
from
760db81 to
1b2bb11
Compare
hahahannes
force-pushed
the
group_access_token
branch
from
1b2bb11 to
b863302
Compare
Contributor
Author
|
@kharkevich Ready for review :) |
Contributor
Author
|
@kharkevich Any thoughts about this? I can also add tests in case this feature seems interesting. |
Member
|
hi @hahahannes, could you please update your PR, resolve conflicts and add unit tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some use cases the
OIDC_GROUPS_ATTRIBUTEtoken field is stored in the access token and not in the user id token. This will also check within the access token.This will close #43