Skip to content

fix: handle string OIDC attributes like Google hd (hosted domain) #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −0
Open

fix: handle string OIDC attributes like Google hd (hosted domain) #162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions mlflow_oidc_auth/auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,9 @@ def handle_user_and_group_management(token) -> list[str]:
user_groups = importlib.import_module(config.OIDC_GROUP_DETECTION_PLUGIN).get_user_groups(token["access_token"])
else:
user_groups = token["userinfo"][config.OIDC_GROUPS_ATTRIBUTE]
# Ensure user_groups is always a list (handles string attributes like 'hd')
if isinstance(user_groups, str):
user_groups = [user_groups]
except Exception as e:
logger.error(f"Group detection error: {str(e)}")
errors.append("Group detection error: Failed to get user groups")
Expand Down
Loading