[WIP] Revamp plugin and migrate CI to GitHub Actions #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from buildCache.local DSL
…educe from error to warning
…support/ best practice / better performance
albertocavalcante
changed the title
mkobit
reviewed
Apr 27, 2025
Owner
mkobit
left a comment
mkobit
left a comment
There was a problem hiding this comment.
I think this looks like an awesome step forward to revamping this project. Are you looking to make any other changes before landing it?
| tasks { | ||
| wrapper { | ||
| gradleVersion = "6.5" | ||
| gradleVersion = "7.6.4" |
Owner
There was a problem hiding this comment.
i'll have to check the expected compatibility matrix, and will most likely target 8.x line so may build on 8.13 or 8.14
Contributor
Author
There was a problem hiding this comment.
My goal is to end targeting the latest Gradle release
I had to stop and work on another stuff for now but I wanted to revisit and maybe open a new PR to add a CI GitHub Action first and maybe breakdown this change into multiple PRs as I know there's a lot to review
mkobit
pushed a commit
that referenced
this pull request
May 19, 2025
## Description This PR only includes the GitHub Actions workflows without removing the existing CircleCI setup. Also, this CI currently runs only on 'ubuntu-latest' runners. I wanted to make as few source code changes as possible. Given that some dependencies were exclusively in JCenter, which has been shut down, I had to make some dependency changes. The idea is for this CI to act as checks and become the first step in revamping this project. This will allow merging the changes at #119 with more confidence. ### Gradle Upgraded Gradle to 6.8 - https://docs.gradle.org/6.8/release-notes.html ```sh ./gradlew wrapper --gradle-version=6.8 ``` ### Other I also included some properties to `.editorconfig` to avoid wildcard imports. These are only applicable to IntelliJ. ### Issues Work towards: - #110 ### Test Evidence I opened a PR in my own fork space to validate this workflow run: https://github.com/albertocavalcante/fork-jenkins-pipeline-shared-libraries-gradle-plugin/pull/1/checks?check_run_id=42265945090 Publish failed due to the missing credentials to publish to Maven Central. Nevertheless, it shouldn't be a priority for now as there's still a long way to go before the next release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Fixes #111
Fixes #110