Fix compatibility with polymode after pm--visible-buffer-name removal

[natsirtguy]

Summary

This PR fixes compatibility with recent polymode changes that removed the pm--visible-buffer-name function in commit 32d0d6d.

Problem

The pm--visible-buffer-name function was removed from polymode and replaced with pm--buffer-name. This caused ein to fail when loading poly-ein.el with an "undefined function" error.

Solution

Replace all instances of pm--visible-buffer-name with pm--buffer-name() in poly-ein.el.

The pm--buffer-name function:

• When called without arguments: pm--buffer-name() - returns the visible buffer name (equivalent to old pm--visible-buffer-name)
• When called with 'hidden: pm--buffer-name('hidden) - returns the hidden buffer name (equivalent to old pm--hidden-buffer-name)

Changes

• Updated poly-ein--record-window-buffer function
• Updated ido-make-buffer-list-hook lambda function
• Updated function documentation strings

Testing

• Code compiles without errors using make test-compile
• Tested functionality in Emacs with Jupyter notebooks
• Buffer switching between polymode buffers works correctly

Compatibility

This change maintains backward compatibility while fixing the issue with polymode >= commit 32d0d6d.

Fixes compatibility with polymode commit: polymode/polymode@32d0d6d

[bjodah]

I've tried these proposed changes and can confirm that it resolves the error with the missing function pm--visible-buffer-name.

As an aside, I ran make dist based on this branch to create my own tarball. But in order to make that build pass with emacs 30.1 I had to apply some other changes too. @natsirtguy I don't know if those additions look relevant to you (perhaps not in this PR), but if you are curious you can see those here:
https://github.com/natsirtguy/emacs-ipython-notebook/compare/fix-polymode-compatibility...bjodah:emacs-ipython-notebook:fix-polymode-compatibility?expand=1

[nailuj05]

I can also confirm this fixes compatibility on emacs 30.1

[emin63]

Can anyone provide hints on how to install?

I built emacs 30.2 from source, compiled ein from https://github.com/bjodah/emacs-ipython-notebook/tree/fix-polymode-compatibility, loaded the compiled ein-autoloads.el, and tried ein:login (after starting a jupyter kernel locally). I then installed dependencies one-by-one from MELPA until ein:login asked me for a URL. At that point I got the following error:

[error] request--callback: could not parse JSON stream: 1, 1, 1
ein: [error] ein:content-query-contents--error http://127.0.0.1:8888/tree?token=REDACTED/ REQUEST-STATUS parse-error DATA (1 1 1)

I had similar issues with emacs 30.1.

Thanks in advance for any help.

[emin63]

Can anyone provide hints on how to install?

Nevermind. The problem was not with my install (at least not directly).

For some reason, if I type the full URL (e.g., http://nethermine:8888/lab?token=REDACTED) then I get strange errors but if I just provide the PORT then everything works fine.

[emin63]

Apologies for the spam. This seems to be the only and last place to go to get EIN working on emacs 30 so I wanted to share a fix for an issue which others may experience.

I had a lot of strange bugs (e.g., Invalid function: ein:log when trying to use pdb in an EIN buffer). After much hair pulling, I discovered that emacs native compilation was causing the trouble (see also #778). I verified this by doing a clean install of ein after disabling native compilation. For a less nuclear option, I believe the following is a way to get a working install:

;; Native compilation causes problems for pdb in ein
;; so prevent native compilation for ein.
(with-eval-after-load 'comp
  (add-to-list 'native-comp-jit-compilation-deny-list "ein"))
(use-package ein
  :straight (ein :type git
                 :host github
                 :repo "natsirtguy/emacs-ipython-notebook"
                 :branch "fix-polymode-compatibility"))

Thanks @natsirtguy and @bjodah for information in this thread which helped me get this working.